Skip to content

feat: Add config-manager push iga-workflows command - #662

Merged
vscheuber merged 3 commits into
rockcarver:mainfrom
trivir:feature/config-manager-push-iga-workflows
Aug 18, 2026
Merged

feat: Add config-manager push iga-workflows command#662
vscheuber merged 3 commits into
rockcarver:mainfrom
trivir:feature/config-manager-push-iga-workflows

Conversation

@dallinjsevy

Copy link
Copy Markdown
Contributor

I added a function to push iga workflow configurations for the frodo config-manager push iga workflows command.

I also added the command implementation file to enable the command.

@dallinjsevy dallinjsevy changed the title feat: Add config-manager pull iga-workflows command feat: Add config-manager push iga-workflows command Aug 11, 2026
@vscheuber
vscheuber force-pushed the feature/config-manager-push-iga-workflows branch from aa2ea2a to 07cf3f9 Compare August 17, 2026 19:29
@vscheuber

Copy link
Copy Markdown
Contributor

@dallinjsevy can you take a look at the failing tests? I rebased the PR but lots of snapshots are still failing (at least in the pipeline).

@vscheuber
vscheuber force-pushed the feature/config-manager-push-iga-workflows branch from 07cf3f9 to 9ed1182 Compare August 18, 2026 13:55
@dallinjsevy

Copy link
Copy Markdown
Contributor Author

@vscheuber Yeah, I'll take a look at those this morning and push the fix.

@dallinjsevy
dallinjsevy force-pushed the feature/config-manager-push-iga-workflows branch from 9ed1182 to 5a880da Compare August 18, 2026 14:42
@phalestrivir

Copy link
Copy Markdown
Contributor

@vscheuber I'm trying to look into it. It looks like it's expecting the snapshot to contain that there's a new frodo version. I just had it reproduced on my local machine, although after I ran a build again (without changing anything) it stopped showing up, so not sure what happened. I'm going to see if I can find a consistent way to reproduce it, but I'm guessing it has to do with how it's getting built in the pipeline

@phalestrivir

Copy link
Copy Markdown
Contributor
image

@vscheuber It looks like the issue is that it is building the binary with version 2.0.0-trivir.2. I have no idea where that's coming from. My understanding is that it should be pulling from the package.json, which has version 4.5.4, but it doesn't seem to be doing that. I'll keep looking into the pipeline.yml to see if there might be a way to fix it to pull the right version

@vscheuber

Copy link
Copy Markdown
Contributor

@phalestrivir yes, I saw that, too, and couldn't really explain it. Let me checkout the PR and run the tests locally. If they succeed, then I'll merge the PR at risk and expect the tests to succeed once everything is in main.

@phalestrivir

Copy link
Copy Markdown
Contributor

@phalestrivir yes, I saw that, too, and couldn't really explain it. Let me checkout the PR and run the tests locally. If they succeed, then I'll merge the PR at risk and expect the tests to succeed once everything is in main.

Ok, let me remove my commit real quick, I was just using it to print out the versions to see why it was failing. I feel like there is an issue with the pipeline not building with the right version, but I'm not familiar enough with it yet to know how it fix it.

@phalestrivir
phalestrivir force-pushed the feature/config-manager-push-iga-workflows branch from 2e85d16 to 5a880da Compare August 18, 2026 18:46
@vscheuber
vscheuber merged commit 67eb7bb into rockcarver:main Aug 18, 2026
1 of 4 checks passed
@vscheuber

Copy link
Copy Markdown
Contributor

@phalestrivir that worked. I think it's getting the version from your repo somewhere. And since the tests really straddle envs between rockcarver and trivir, somehow your version must have slipped into this PR. I don't recall this ever happening with any other of your PRs. But I checked out the PR, ran the tests locally and they succeeded, so I merged at risk and the release just popped out.

@phalestrivir

Copy link
Copy Markdown
Contributor

@phalestrivir that worked. I think it's getting the version from your repo somewhere. And since the tests really straddle envs between rockcarver and trivir, somehow your version must have slipped into this PR. I don't recall this ever happening with any other of your PRs. But I checked out the PR, ran the tests locally and they succeeded, so I merged at risk and the release just popped out.

That's very interesting. Yeah, I have no idea how that slipped in with the PR. My only guess would be that the branch may have initially been created off of our trivir branch in our repo and then was later rebased with the main branch (which we keep synced with the Rockcarver main branch), but usually we try to branch off of main so we don't have to do that. Either way, I'm glad it worked out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants