fix: type LEDPattern map_index callback as int - #329
Closed
Amidwestnoob wants to merge 1 commit into
Closed
Amidwestnoob wants to merge 1 commit into
Amidwestnoob wants to merge 1 commit into
Conversation
Callers use (int, int) -> int. Own the callback via shared_ptr with gil_scoped_acquire on destroy and invoke so apply_to release_gil is safe. Fixes robotpy#168
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #168
Problem
LEDPattern.map_indexstubs typed the callback asCallable[[SupportsInt | SupportsIndex, SupportsInt | SupportsIndex], int].Callers pass
(length: int, idx: int) -> int. Callback parameters arecontravariant, so Pylance/mypy reject valid mappers.
Fix
Bind
MapIndexwithpy::typing::Callable<py::int_(py::int_, py::int_)>sogenerated stubs emit
Callable[[int, int], int]. Own the Python callable asshared_ptr<py::function>withgil_scoped_acquireon invoke and destroy,matching
TelemetryRegistry::SetReportWarning, becauseapply_tousesrelease_gil().index_mapperrejectsNone(disable_none).Tests
./rdev.sh develop --stop-at robotpy-wpilibregeneratedCallable[[int, int], int]at__init__.pyiline 10041.map_index(None)TypeError; callback survives return and isinvoked from
apply_to; reverse remap completes without crash.Does not retarget other
SupportsIntcallback stubs.