fix(ntcore): register bool put/set overloads before double - #324
Closed
Amidwestnoob wants to merge 1 commit into
Closed
Amidwestnoob wants to merge 1 commit into
Amidwestnoob wants to merge 1 commit into
Conversation
Under pybind11 3.1, Python bool subclasses int and can bind the double overload when it is registered first. Put bool first with noconvert so True/False stay boolean NT values. Closes robotpy#318
Member
|
If you're going to use a clanker, at least add tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boolcan bind the earlierdoubleoverload becauseboolsubclassesint.booloverload first, with.noconvert()on the value, for:NetworkTable.put_value/set_default_valueNetworkTableEntry.set_value/set_default_valuetest_getvalue_overloadscoversput_value("boolean", True).Closes #318
Test plan
tests/test_network_table.py::test_getvalue_overloadsput_value(..., True)stores a boolean, while numeric1/1.0still store doubles