Skip to content

✨ feat(workflows): preserve native OBB contributors in consensus - #3278

Closed
cfviotti wants to merge 1 commit into
caio/obb-consensus-base-2420from
caio/native-obb-consensus
Closed

cfviotti wants to merge 1 commit into
caio/obb-consensus-base-2420from
caio/native-obb-consensus

Conversation

@cfviotti

@cfviotti cfviotti commented Oct 27, 2026 •

Copy link
Copy Markdown

Superseded by the current Workflows integration, #3280, which ports the prerequisite to canonical package paths and verifies actual serialized Workflow execution in both native representations. This older review branch is closed.

Description

Preserve native oriented geometry and front when consensus combines contributors. Matching reuses the rotated IoU path from #2420. Native output retains the highest-confidence contributor of the aggregated output class, with source-order ties; its ordered corners, heading capability and identity stay together, while confidence uses the existing aggregation setting. Native/ordinary mixtures, missing geometry/front and conflicting heading capabilities are errors.

Ordinary box/mask aggregation is unchanged. Native coordinates intentionally use this contributor-selection policy rather than the ordinary coordinate aggregation setting.

Dependencies and limits

This followup is based on #2420 at ee7fe5288255df1c8401877feda3ddaca0118eef. Its base branch caio/obb-consensus-base-2420 is an exact mirror of that commit because the prerequisite lives in a contributor fork; the mirror is a review base, not a branch to merge separately. That branch predates the standalone Workflows package migration. The native output kind and serializer prerequisite must be reconciled after its rebase before enabling native block selection; this branch alone does not advertise a complete native consensus flow. It does not copy the v2 implementation onto current main.

Validation

PYTHONPATH=. python -m pytest tests/workflows/unit_tests/core_steps/fusion/test_detections_consensus_v2.py tests/workflows/unit_tests/core_steps/fusion/test_native_obb_consensus.py -q --confcutdir=tests/workflows/unit_tests/core_steps/fusion — 15 passed.

Fixtures include same-footprint opposite fronts, deterministic contributor ties, all confidence aggregation modes, frozen heading conflicts and refusal to fall back to AABB overlap when native corners are missing.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cfviotti cfviotti closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants