Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by the current Workflows integration, #3280, which ports the prerequisite to canonical package paths and verifies actual serialized Workflow execution in both native representations. This older review branch is closed.
Description
Preserve native oriented geometry and front when consensus combines contributors. Matching reuses the rotated IoU path from #2420. Native output retains the highest-confidence contributor of the aggregated output class, with source-order ties; its ordered corners, heading capability and identity stay together, while confidence uses the existing aggregation setting. Native/ordinary mixtures, missing geometry/front and conflicting heading capabilities are errors.
Ordinary box/mask aggregation is unchanged. Native coordinates intentionally use this contributor-selection policy rather than the ordinary coordinate aggregation setting.
Dependencies and limits
This followup is based on #2420 at
ee7fe5288255df1c8401877feda3ddaca0118eef. Its base branchcaio/obb-consensus-base-2420is an exact mirror of that commit because the prerequisite lives in a contributor fork; the mirror is a review base, not a branch to merge separately. That branch predates the standalone Workflows package migration. The native output kind and serializer prerequisite must be reconciled after its rebase before enabling native block selection; this branch alone does not advertise a complete native consensus flow. It does not copy the v2 implementation onto current main.Validation
PYTHONPATH=. python -m pytest tests/workflows/unit_tests/core_steps/fusion/test_detections_consensus_v2.py tests/workflows/unit_tests/core_steps/fusion/test_native_obb_consensus.py -q --confcutdir=tests/workflows/unit_tests/core_steps/fusion— 15 passed.Fixtures include same-footprint opposite fronts, deterministic contributor ties, all confidence aggregation modes, frozen heading conflicts and refusal to fall back to AABB overlap when native corners are missing.