Repository navigation
Resolve security issues with dependencies bump - #3274
Conversation
|
👋 Thanks for the pull request! Here is how automated Claude review works here, so you spend credits (and reviewer time) wisely. 🚦 This PR is marked Ready for review, so automated Claude review will run — and every pass spends real credits. Warning 💸 The Claude reviewer bills in credits, not vibesAutomated review spins up a real agent that reads real code and spends real credits on every pass. It is glad to help — but it is not a rubber duck, a linter you poke in a loop, or a substitute for reading the contributing guide. Treat it like an expensive senior reviewer whose time you booked, and show up prepared. Draft when unsure, Ready when you mean it:
However you get there, arrive prepared:
Reviews are not free. A draft costs nothing to review; a Ready PR is a promise that it is worth reviewing.
|
|
🤖 Claude review started at commit New commits are not auto-reviewed. Add the |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| requests-toolbelt~=1.0.0 | ||
| wheel>=0.38.1,<=0.45.1 | ||
| setuptools>=83.0.0 # lack of upper-bound to ensure compatibility with Google Colab (builds to define one if needed) | ||
| setuptools>=84.1.0 # lack of upper-bound to ensure compatibility with Google Colab (builds to define one if needed) |
There was a problem hiding this comment.
High: this conflicts with the setuptools~=83.0.0 pins still in the Dockerfiles, so Docker image builds will fail to resolve.
Most Dockerfiles install this file together with a hard setuptools~=83.0.0 (which means >=83.0.0,<83.1) in a single pip install. For example, docker/dockerfiles/Dockerfile.onnx.cpu:40-53:
-r _requirements.txt \ # now setuptools>=84.1.0
-r requirements.cpu.txt \ # inference-models==0.39.6 -> setuptools>=84.1.0
...
"setuptools~=83.0.0" \
pip can't satisfy both, so it fails with ResolutionImpossible. The same pin also appears in the wheel-install step (Dockerfile.onnx.cpu:62, dist/inference_core*.whl ... "setuptools~=83.0.0"), and inference_core's install_requires reads _requirements.txt.
Other files with the same ~=83.0.0 pin: Dockerfile.onnx.{cpu.dev,cpu.slim,cpu.parallel,gpu,gpu.dev,gpu.slim,gpu.3d,gpu.parallel,udp.gpu,trt,cu13.gpu} and Dockerfile.onnx.jetson.{5.1.1,6.2.0}. Unless they change, every CPU, GPU and Jetson server image breaks on the next build.
Fix: change these Dockerfile pins to setuptools~=84.2 (or >=84.1.0,<85) in this PR. Also check whether Dockerfile.wheels.jetson.7.2.0 (setuptools>=77,<82) installs inference-models in the same environment.
Claude review summaryStatus: blocked. One High finding needs fixing before this can merge. Skills: review-packaging-ci, review-inference-models-pkg, review-topic-backward-compat-and-versioning, review-topic-test-hygiene No dedicated surface skill covers Findings
What checks out
Tests to add
Commands that informed this review
Reviewed at HEAD: 7443530 |
Release coordination (maintainers)This PR needs release-time version changes for inference-models ( The version strings, pins and changelog headings are already in this PR. Publishing uses Reviewed at HEAD: 7443530 |
What does this PR do?
Resolve security issues with dependencies that could be easily bumped.
Type of Change
Testing
Test details:
Checklist
Additional Context