Repository navigation
Right-size the package install test and docs runners - #3170
Conversation
The SDK and CLI install tests only need the inference-sdk and inference-cli wheels, so build those with the existing create_inference_cli_whl target instead of create_wheels, which also installs the full inference requirements (including torch) only to build wheels that these jobs never use. With that gone, both jobs do little work and move to the small runner. The inference and inference-with-extras install tests are mostly pip downloads and single-threaded wheel builds, so move them from 8 to 4 cores.
The docs site is now a landing page plus redirects. The job installs a few packages and the build itself takes under a second, so a 32-core runner is not needed.
|
👋 Thanks for the pull request! Here is how automated Claude review works here, so you spend credits (and reviewer time) wisely. 🚦 This PR is marked Ready for review, so automated Claude review will run — and every pass spends real credits. Warning 💸 The Claude reviewer bills in credits, not vibesAutomated review spins up a real agent that reads real code and spends real credits on every pass. It is glad to help — but it is not a rubber duck, a linter you poke in a loop, or a substitute for reading the contributing guide. Treat it like an expensive senior reviewer whose time you booked, and show up prepared. Draft when unsure, Ready when you mean it:
However you get there, arrive prepared:
Reviews are not free. A draft costs nothing to review; a Ready PR is a promise that it is worth reviewing.
|
|
🤖 Claude review started at commit New commits are not auto-reviewed. Add the |
|
Claude review summary: no blocking findings. Skills: review-packaging-ci, review-topic-test-hygiene What I checked in the code:
Not blocking: the Commands that informed the review: Reviewed at HEAD: bd032b1 |
|
😎 PR passes the vibe-check and trust-me-bro verification. |
Why
The four CPU
Test package installworkflows run on 8-core runners after every push to main, and the docs workflow uses a 32-core runner. None of them uses that many cores.make create_wheels, which installs the full inference requirements (torch included) and builds seven wheels, only to installinference-sdk(andinference-cli). That step took about 100s of a 176 to 195s job.inferenceandinference[extras]jobs are pip downloads, unpacking and single-threadedsetup.py bdist_wheelcalls.pip install, and the build step itself takes under a second (37976849427).Change
create_inference_cli_whltarget, and run ondepot-ubuntu-22.04-small.inferenceandinference[extras]install tests:depot-ubuntu-22.04-8todepot-ubuntu-22.04-4.depot-ubuntu-22.04-32todepot-ubuntu-22.04-small.Timings
Mean job time per run, 4 Python versions each. Before: the 4 most recent successful push runs on main. After: 3
workflow_dispatchruns of this branch.All 48 dispatched jobs passed. "Create Wheels" averaged 90s and 95s on 4 cores, compared with 97s and 125s on 8 cores. In the SDK and CLI jobs it now takes 2s. Most of what remains there is "Cache Python packages" restoring a 4 to 15 GB pip cache, which #3165 addresses.
Docs job on pull requests: 70, 73, 89 and 72s on 32 cores (37976849427, 37970090210, 37969385504, 37966804862), 45s on the small runner for this pull request (38121521235). Release and manual deploy runs do the same steps plus
ghp-import.