fix: SwaleBoroughCouncil - handle relative date strings#2002
fix: SwaleBoroughCouncil - handle relative date strings#2002InertiaUK wants to merge 1 commit intorobbrad:masterfrom
Conversation
The council page shows "is due today" or "is due tomorrow" as the collection date on the day of (or day before) collection. The parser used an exact string match for "is due today" which broke on case variations. Switched to case-insensitive substring matching and added "tomorrow" handling.
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 59 minutes and 31 seconds.Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2002 +/- ##
=======================================
Coverage 86.67% 86.67%
=======================================
Files 9 9
Lines 1141 1141
=======================================
Hits 989 989
Misses 152 152 ☔ View full report in Codecov by Sentry. |
Swale's bin page shows "is due today" or potentially "is due tomorrow" as the collection date text on collection day. The existing parser had an exact-match check (
== "is due today") which failed intermittently on case or whitespace variations.Changes:
"today" in normalised) instead of exact equalityThe scraper was failing intermittently when the cron ran on collection day for the test address, then self-recovering the next day. This makes it reliable regardless of when it runs.