Repository navigation
refactor(rozier): move twig templates to role tree - #558
Draft
timothejoubert wants to merge 2 commits into
Draft
timothejoubert wants to merge 2 commits into
timothejoubert wants to merge 2 commits into
Conversation
added 2 commits
October 30, 2026 15:58
Move layouts to layouts/, layout regions to patterns/ and every rz-* component to components/, following lib/Rozier/docs/templates.md (ADR 0005). Merge the duplicated components (dropdown + dropdown menu, breadcrumb + item, both repeatables, both filters bars, bulk macros into rz_bulk_actions) and remove the unreferenced templates. Every moved, merged or removed path is listed in UPGRADE.md "Upgrade to 2.8". Refs #540
timothejoubert
marked this pull request as draft
October 30, 2026 15:38
Contributor
Author
|
Change of plan: breaking changes must be avoided as much as possible, including for this template move. As it stands, this PR breaks every project that includes, embeds, extends or overrides one of the moved On hold until that ADR is written; this PR will then be reworked to follow it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #540 — PR 1 of 3 (tree). PR 2 (options keys + header comment) and PR 3 (hand-written roots) follow.
Summary
Shared templates move to the role-based tree of
lib/Rozier/docs/templates.md(ADR 0005).layout.html.twig,forms.html.twiganddashboard/index.html.twigstay put.Duplicates merged into one component file:
Removed: the 11 unreferenced templates listed in #540, plus
widgets/backlinkandwidgets/itemPerPage(only used by them). Every moved, merged or removed path is inUPGRADE.md→ "Upgrade to 2.8". Comments in renderers and stories (incl. those added by #557) point at the new paths.Evidence
grepof every old path overlib src templates config docs→ nothing left (outside CHANGELOG / UPGRADE history); every@RoadizRozier/…reference resolves to an existing file.lint:twig: OK on the 5 template folders.node-types/decorators/addmissing param, 2FA backup codes without 2FA,articlesshadow root missing in fixtures ×2). Merged markup present in the HTML (repeatable, dropdown trigger, breadcrumb overflow, bulk actions, filters bar), repeatable item content not double-escaped.developin the local env (576 tests, same 5 errors / 3 failures before and after).Click-through, both themes:
Merge Danger
Door: one-way
Projects that
include/embed/extendsor override@RoadizRozier/…shared templates break on 2.8; this is the break ADR 0005 accepts, documented inUPGRADE.md. Reverting inside the repo stays easy (moves + path rewrites).Blast Radius: backoffice-wide
Every backoffice screen goes through moved layouts/components; a missed path is a 500 on render, which the smoke run covered for GET screens (AJAX tree endpoints only checked statically).
Open points, not in this PR:
includeof components (filters bar, table actions, drawer, repeatable…) contradict "a component is never pulled in withinclude" → PR 2.docs/extensions/backoffice_templates.mddocumentslayouts/adminandlayouts/head, which makes them public per ADR 0006 whiletemplates.mdlists only components/patterns: keep or drop?rz_drawer,rz_geotagopen on<rz-form-field>,rz_color_scheme_switcheron<rz-popover>: file names follow the component, not the outer root.id ~ '_repeatable'|default(...)inrz_repeatablenever applies the default.