Skip to content

ci(release): fix invalid env context in the prebuilt workflow call - #2481

Merged
ni4 merged 1 commit into
mainfrom
fix-release-workflow-env-context
Sep 4, 2026
Merged

ci(release): fix invalid env context in the prebuilt workflow call#2481
ni4 merged 1 commit into
mainfrom
fix-release-workflow-env-context

Conversation

@ronaldtse

Copy link
Copy Markdown
Contributor

Summary

  • release.yml has failed with a workflow-file issue on every trigger since it was introduced - actionlint pinpoints it: the prebuilt job calls the reusable prebuilt.yml with tag: env.RELEASE_TAG, but the env context is not allowed in a caller's job-level with: (only github/needs/vars/inputs).
  • Fixed by computing the tag with the allowed contexts - identical semantics to the workflow-level env definition the other jobs use.
  • Verified locally: actionlint fails on the original file at exactly that line and passes with the fix.

Test plan

  • actionlint/CI green
  • next tag push or workflow dispatch of release.yml starts jobs instead of failing with a workflow file issue

The job-level with: of a reusable workflow caller may only use the
github/needs/vars/inputs contexts, so the env.RELEASE_TAG reference made
GitHub reject the whole workflow file - every run of release.yml has
failed with a "workflow file issue" since the workflow was introduced.
Compute the tag from the github/inputs contexts instead.
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.46%. Comparing base (100cc8c) to head (c9bcd18).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2481   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files         125      125           
  Lines       22962    22962           
=======================================
  Hits        19625    19625           
  Misses       3337     3337           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ronaldtse

Copy link
Copy Markdown
Contributor Author

@ni4 one-line workflow fix for your class: release.yml has failed with a workflow-file issue on every trigger since it was introduced - the prebuilt job passes env.RELEASE_TAG to the reusable workflow, but the env context is not allowed in a caller's job-level with: (actionlint pinpoints the exact line). Now computed from the github/inputs contexts instead. All checks green except the known fuzzing exceptions.

@ronaldtse
ronaldtse requested a review from ni4 September 3, 2026 08:50

@ni4 ni4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging with single approval as CI-only.

@ni4
ni4 merged commit 43a58a1 into main Sep 4, 2026
145 of 148 checks passed
@ni4
ni4 deleted the fix-release-workflow-env-context branch September 4, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants