Repository navigation
fix(pegboard-gateway): send the client close without waiting on the envoy - #5874
Open
eersnington wants to merge 1 commit into
Open
eersnington wants to merge 1 commit into
eersnington wants to merge 1 commit into
Conversation
eersnington
added this pull request to stack #5875
October 13, 2026 21:11
Contributor
|
Review The change is small and the approach is sound. On a server close, the client close frame no longer waits for an envoy that may already be gone. Client closes and aborts keep the old ordering. I haven't built or tested this branch.
Overall this looks good, and I would address 1 and 4 before merging. |
This was referenced Oct 13, 2026
eersnington
force-pushed
the
fix/gateway-close-without-envoy-ack
branch
from
October 13, 2026 21:18
2d4543b to
d938ed2
Compare
eersnington
force-pushed
the
fix/gateway-close-without-envoy-ack
branch
from
October 14, 2026 20:40
d938ed2 to
d019175
Compare
eersnington
removed this pull request from stack #5875
October 14, 2026 20:40
eersnington
added this pull request to stack #5879
October 14, 2026 20:40
This was referenced Oct 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an actor closes a client WebSocket and its runner shuts down right after, as in a drain, the client waited up to 30s for the close frame. On a server close, the gateway first sent the close back to the envoy and waited for it. With the envoy already gone,
send_messageretried until it timed out, and only then sent the close frame to the client.pegboard-gateway2andpegboard-gateway3send the close back to the envoy in a background task, so the client gets its close frame right away.This is part 2 of 6 in a stack: