Skip to content

fix(ci): lint error and sdk test timeout - #357

Merged
eersnington merged 2 commits into
mainfrom
fix/ci-lint-and-sdk-image
Oct 14, 2026
Merged

eersnington merged 2 commits into
mainfrom
fix/ci-lint-and-sdk-image

Conversation

@eersnington

@eersnington eersnington commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Two fixes for CI on main. Both CI jobs fail on main and on every open PR.

Job Failure Fix
packages pnpm lint: Biome format error in packages/pi/src/runtime.ts (from #351) Format the file.
checks Run SDK tests: the first beforeEach times out after 120s Time out each health request in waitForHealth().

SDK test timeout

waitForHealth() checks its deadline only between requests, and fetch has no timeout. Undici waits up to 300s for response headers.

The first health request to the first container of the run connects, then gets no response. That one request holds beforeEach until Vitest kills it at 120s. Health requests to later containers fail fast with UND_ERR_SOCKET, so the retry loop works for them.

sequenceDiagram
  participant T as beforeEach
  participant C as first container
  T->>C: GET /v1/health
  Note over T,C: Before: no response, the hook waits until the 120s hookTimeout
  Note over T,C: After: aborts at 2s
  T->>C: GET /v1/health (retry)
  C-->>T: 200
Loading
// sandbox-agent/sdks/typescript/tests/helpers/docker.ts
const response = await fetch(`${baseUrl}/v1/health`, { signal: AbortSignal.timeout(2_000) });

@railway-app

railway-app Bot commented Oct 14, 2026

Copy link
Copy Markdown

This PR was not deployed automatically as @eersnington does not have access to the Railway project.

In order to get automatic PR deploys, please add @eersnington to your workspace on Railway.

@eersnington eersnington changed the title ci: fix lint error and SDK test image timeout ci: fix lint error and rust sdk tests Oct 14, 2026
@eersnington eersnington changed the title ci: fix lint error and rust sdk tests fix(ci): lint error and rust sdk tests Oct 14, 2026
waitForHealth checked its deadline only between requests, and fetch has
no timeout. A health request that connected but never got a response
hung the first beforeEach until the 120s hookTimeout.
@eersnington
eersnington force-pushed the fix/ci-lint-and-sdk-image branch 2 times, most recently from 8afe977 to 37f778c Compare October 14, 2026 00:44
@eersnington eersnington changed the title fix(ci): lint error and rust sdk tests ci: fix lint error and SDK test health check hang Oct 14, 2026
@eersnington eersnington changed the title ci: fix lint error and SDK test health check hang fix(ci): lint error and sdk test timeout Oct 14, 2026
@eersnington
eersnington merged commit 81e7a71 into main Oct 14, 2026
3 checks passed
@eersnington
eersnington deleted the fix/ci-lint-and-sdk-image branch October 14, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant