Repository navigation
fix(ci): lint error and sdk test timeout - #357
Merged
Merged
Conversation
|
This PR was not deployed automatically as @eersnington does not have access to the Railway project. In order to get automatic PR deploys, please add @eersnington to your workspace on Railway. |
waitForHealth checked its deadline only between requests, and fetch has no timeout. A health request that connected but never got a response hung the first beforeEach until the 120s hookTimeout.
eersnington
force-pushed
the
fix/ci-lint-and-sdk-image
branch
2 times, most recently
from
October 14, 2026 00:44
8afe977 to
37f778c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for CI on
main. Both CI jobs fail onmainand on every open PR.packagespnpm lint: Biome format error inpackages/pi/src/runtime.ts(from #351)checksRun SDK tests: the firstbeforeEachtimes out after 120swaitForHealth().SDK test timeout
waitForHealth()checks its deadline only between requests, andfetchhas no timeout. Undici waits up to 300s for response headers.The first health request to the first container of the run connects, then gets no response. That one request holds
beforeEachuntil Vitest kills it at 120s. Health requests to later containers fail fast withUND_ERR_SOCKET, so the retry loop works for them.