Repository navigation
fix(pi): accept typed connection hooks in pi() - #354
Merged
Merged
Conversation
|
This PR was not deployed automatically as @eersnington does not have access to the Railway project. In order to get automatic PR deploys, please add @eersnington to your workspace on Railway. |
eersnington
force-pushed
the
fix/pi-conn-hook-types
branch
from
October 14, 2026 00:57
18a5a14 to
c5cdfba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pi()constrainedTUserActionswithPiUserActions<...>. TypeScript did not infer the connection state type fromcreateConnStatethrough that constraint, so app actions sawc.conn.stateand connection params without their types and needed casts.Now the actions in the config are typed through an intersection with
UserActions<...>, andTUserActionsis a plainRecord<string, unknown>. The action'sctakes its type from the config, soc.conn.statehas the type thatcreateConnStatereturns:actor-types.ts:actions?: TUserActions & UserActions<TState, TConnParams, TConnState, ...>.actor.ts:TUserActions extends Record<string, unknown>inPiActorConfigInputandpi().tests/connection-hooks.test.ts: a bad token is rejected on a built-in call, and a good token connects and the app's action readsc.conn.state.