Repository navigation
diffq-fixed: Add version 0.2.4 - #3045
Merged
Merged
Conversation
Fork of facebookresearch/diffq with Python 3.11+ compat fixes. Same plain Cython extension (diffq.bitpack) as upstream diffq, no torch/CUDA headers at build time. The published PyPI sdist omits bitpack.pyx (missing from MANIFEST.in), so this builds from a pinned upstream commit (JackismyShephard/diffq has no tags) whose tree matches the released 0.2.4 wheels instead.
luhenry
added a commit
that referenced
this pull request
Oct 13, 2026
diffq-fixed is a Python 3.11+ compat fork of the already-queued diffq (same diffq.bitpack Cython extension); build from a pinned commit since the fork has no tags and its PyPI sdist omits bitpack.pyx. amplpy looked like the aimmspy/gotcha-652 shape but verified out as distinct: the bindings are honestly BSD-3/open-source, but the Cython extension links at build time against a closed, prebuilt-only libampl.so with no riscv64 build anywhere and no public source. Added gotcha 653 for this "open bindings, closed build-time native shim" shape.
luhenry
marked this pull request as draft
October 14, 2026 11:35
luhenry
marked this pull request as ready for review
October 16, 2026 02:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diffq-fixed0.2.4A plain Cython extension (
diffq.bitpack), no torch/CUDA headers at build time. Upstream publishes no riscv64 wheel.Mirrors upstream's
build.yml, same shape as the siblingdiffqport (PR #2991).Differs from upstream
bitpack.pyx(missing fromMANIFEST.in).Testing
diffq.bitpackand the test suite are unchanged from the siblingdiffqpackage since this fork's 0.2.4 version bump.License: Wheel ships upstream's CC BY-NC-4.0
LICENSEunchanged, same as the already-queueddiffqpackage.No local rehearsal (disk-constrained host); relying on CI's riscv64 runner. The identical
diffq.bitpackextension and test suite already rehearsed clean for the siblingdiffqPR: 29 passed, 1 deselected (needs torchvision).