Repository navigation
lancedb: Add version 0.40.0 - #2827
Draft
riseproject-dev[bot] wants to merge 4 commits into
Draft
riseproject-dev[bot] wants to merge 4 commits into
riseproject-dev[bot] wants to merge 4 commits into
Conversation
Signed-off-by: riseproject-dev[bot] <330740410+riseproject-dev[bot]@users.noreply.github.com>
Contributor
|
Nightly version bump omitted the patches/lancedb/<version> directory for 0.40.0, so the build's unconditional `git apply .../*.patch` step failed with "No such file or directory" before any build/test ran. Copied forward the same patch set from 0.39.0 (unchanged since then).
lancedb v0.40.0 pins lance-core/lance-linalg =13.0.0, and lance 13.0.0 ships the portable SIMD fallback the 0002 patch carried (lance-format/lance#9446, "fix(linalg): build on architectures without SIMD kernels"): lance-linalg's build.rs now emits `cfg(simd_fallback)` for every target_arch other than x86_64/aarch64/loongarch64, and f32x8/f32x16/f64x4/f64x8/i32x8 gain an array-backed struct plus a scalar arm in each method under that cfg, inserted right after the per-arch struct definitions -- which is why the 0002 hunks no longer apply there. Rebasing them would define each type twice on riscv64, so both patches go: with no local lance fix to point at, the 0001 Cargo.toml redirect is moot and the crates.io lance 13.0.0 in lancedb's Cargo.lock is used as released. The patch-apply and lance-checkout steps now run only when the version being built has patches under patches/lancedb/<version>/, the same hashFiles() gate build-fastparquet.yml uses, so the 0.37.1-0.39.0 path is unchanged. Checked by type-checking lance v13.0.0's simd/{f32,f64,i32,u8}.rs for riscv64gc-unknown-linux-gnu: clean with simd_fallback set, and the old "cannot find type `f32x8`" errors without it. Signed-off-by: Ludovic Henry <git@ludovic.dev>
lance >= 13.0.0 (lancedb >= v0.40.0) ships the riscv64 SIMD fallback itself, so patches/lancedb/0.40.0/ doesn't exist and the unconditional git apply/checkout steps would fail on the unexpanded glob.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically generated by the nightly
check_versions.pyrun.lancedb v0.39.0 -> v0.40.0
Every
- version:entry added todocs/packages/lancedb.yamlis built by this PR's ownbuild-lancedb.ymlrun; merging publishes the wheels.