Repository navigation
array-record: Fix bazel-bootstrap env var name mismatch - #2125
Merged
Merged
Conversation
The bootstrap script's rules_python download interpolated
${PROJECT_RULES_PYTHON_VERSION}, but its `docker run` only passes
`-e RULES_PYTHON_VERSION` into the container. PROJECT_RULES_PYTHON_VERSION is
set solely in the build_wheels job, so under the script's own `set -eux` that
curl would abort on an unbound variable.
The bootstrap wants bazel 7.5.0's pinned rules_python (0.33.2) - the version
whose toolchains_repo.bzl the following sed patches - which is what the
workflow-level RULES_PYTHON_VERSION holds; the build job's 1.6.0 is
array_record's own rules_python and patches a different file. build-ray.yml
and build-labmaze.yml use the correct form for this recipe.
This stayed latent because the cache key bazel-7.5.0-manylinux_riscv64 is
shared across workflows, so the bootstrap step has been skipped on a cache hit
on every run so far.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array-record(already published; no version change).github/workflows/build-array-record.ymlThe bazel bootstrap job's rules_python download interpolated
${PROJECT_RULES_PYTHON_VERSION}, but itsdocker runonly passes-e RULES_PYTHON_VERSIONinto the container.PROJECT_RULES_PYTHON_VERSIONis set only in thebuild_wheelsjob, so under the bootstrap script'sset -euxthat download aborts on an unbound variable.The bootstrap wants bazel 7.5.0's pinned rules_python (0.33.2), whose
toolchains_repo.bzlthe adjacentsedpatches — that is the workflow-levelRULES_PYTHON_VERSION. The build job's1.6.0is array_record's own rules_python and patches a different file, so the two are not interchangeable.build-ray.ymlandbuild-labmaze.ymlalready use the corrected form for the same recipe, and the line now matches theirs exactly.The bug is latent rather than breaking: the cache key
bazel-7.5.0-manylinux_riscv64is shared across workflows, so the bootstrap step is skipped on a cache hit and has never executed this path. It would fail on the first cache miss.Testing: none needed — no rebuild is triggered and the published 0.8.3 wheels are unaffected. Every
${VAR}the bootstrap heredoc expands is now either assigned in the script or named in a-eflag on itsdocker run.