Skip to content

Classify normative tag markup-only changes - #244

Closed
Rafael Sene (rpsene) wants to merge 1 commit into
riscv:mainfrom
rpsene:norm-tag-markup-classification
Closed

Rafael Sene (rpsene) wants to merge 1 commit into
riscv:mainfrom
rpsene:norm-tag-markup-classification

Conversation

@rpsene

Copy link
Copy Markdown
Contributor

No description provided.

@wmat

Copy link
Copy Markdown
Collaborator

Rafael Sene (@rpsene) is this still valid?

@rpsene

Copy link
Copy Markdown
Contributor Author

No, it is not. This one has been overtaken.

#244 improved tools/detect_tag_changes.py so markup-only edits to a normative
tag would not be reported as content changes. The script's only consumer was the
check-normative-tags workflow in riscv-isa-manual, and that went away in
riscv/riscv-isa-manual#3334 when James withdrew the original request in
riscv/riscv-isa-manual#2145. You then removed the script itself in #260, which is
the right call, and I confirmed there are no remaining references to it anywhere
in the riscv org.

Closing this. If we ever bring the check back, the markup-versus-content
classification and the two fixture files in this PR are the part worth reviving,
so the diff is worth a look before rewriting it from scratch.

Thanks for chasing it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants