Skip to content
This repository was archived by the owner on May 29, 2024. It is now read-only.
This repository was archived by the owner on May 29, 2024. It is now read-only.

'total' argument in BaseList.paginate needed? #82

Description

@toirl

The paginate method of the BaseList has since recent versions a new 'total' argument. I am currently not sure why this needs to be provided to the method as the total size if the list can be obtained from the list itself. This change breaks the API in other applications as the call of paginate now requires an extra argument.

7fbf08a sets a default value for total and set the value to the len of self.items. This seems to be OK in most cases.

TODO:
Check if there is any usecase where providing total as extra argument makes sense.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions