Repository navigation
Package zips: no __MACOSX tree, no .DS_Store (ID 182) - #51
Merged
Merged
Conversation
ditto --sequesterRsrc wrote resource forks and extended attributes as a __MACOSX/._* tree (89 entries in the 0.3.0 Max zip), and Finder's .DS_Store files were copied along with media/ and the bundles. The zip helper in build.sh and the CI step now use --norsrc and delete .DS_Store before zipping; the CMake install rules exclude .DS_Store where they copy whole folders; CI fails the Max job if the zip still carries either. Permissions and the ad-hoc signatures are untouched (checked: codesign --verify --deep --strict on the unzipped bundles). The -p step also drops every stale zip in dist/, not only the ones with the current naming. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Board ID 182, zip hygiene from the 2026-10-16 package audit.
build.sh zip_dir()and the CI "Assemble the Max package" step zip withditto -c -k --norsrcinstead of--sequesterRsrc, so no__MACOSX/._*AppleDouble tree is written (the 0.3.0 zip had 89 such entries), and delete.DS_Storefiles before zipping.maxmsp/CMakeLists.txtexcludes.DS_Storewhere whole folders are copied (media/, the.mxobundles); theFILES_MATCHINGrules already skipped it.__MACOSXor.DS_Store../build.sh -premoves every stale zip indist/, not only those with the current naming.unzip -l.Verified locally:
./build.sh -p maxmspgives a 65-entry zip with no metadata files; after unzipping,codesign --verify --deep --strictpasses on all four bundles,lipo -archssays arm64, the executables keep-rwxr-xr-x.🤖 Generated with Claude Code