Repository navigation
ci: a final release tag is not a prerelease - #49
Merged
Merged
Conversation
The release job marked every release as a prerelease because it looked for a hyphen in the whole tag name, and max-v0.3.0 has one in its host prefix. Test the version part instead, so only a suffixed version (0.3.0-rc1) becomes a prerelease. Seen on the max-v0.3.0 draft, which was corrected by hand with gh release edit. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
releasejob decided--prereleasewithcase "$GITHUB_REF_NAME" in *-*). Every host tag contains a hyphen in its prefix (max-v,pd-v), so the finalmax-v0.3.0draft came out as a prerelease. The check now looks at the version part only, somax-v0.3.0-rc1stays a prerelease andmax-v0.3.0does not.The
max-v0.3.0draft itself was corrected withgh release edit --prerelease=false; this PR fixes the next one.Test plan
VERSIONis${tag#max-v}from the guard step, so0.3.0has no hyphen and0.3.0-rc1doesprerelease=false🤖 Generated with Claude Code