security: validate language codes before dynamic import to prevent path traversal#874
Open
smartalee wants to merge 1 commit into
Open
security: validate language codes before dynamic import to prevent path traversal#874smartalee wants to merge 1 commit into
smartalee wants to merge 1 commit into
Conversation
…th traversal - Add validation against SUPPORTED_LANGUAGES allowlist before dynamic import - Reject path traversal strings like ../../lib/secrets - Fall back to English for unsupported language codes - Add security tests for path traversal prevention Closes rinafcode#719
Contributor
|
Great job so far There’s just one blocker — merge conflict. Could you take a look and resolve it? Happy to review again once that’s done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes path traversal vulnerability in the translation manager by validating language codes against an allowlist before dynamic import.
Changes
SUPPORTED_LANGUAGESbeforeawait import()../../etc/passwdare rejectedSecurity
SUPPORTED_LANGUAGESis the single source of truth for allowed localesCloses #719