feat(teachLink_web): bug-login-route-accepts-any-password-of-6-charac#832
Merged
Conversation
|
@Caneryy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Sync pnpm-lock.yaml after adding bcrypt dependencies - Fix prettier formatting in login route - Correct signup/login route imports in a11y auth tests
Contributor
Author
|
@RUKAYAT-CODER2025 review and merge please |
Contributor
|
Great job so far There’s just one blocker — the workflow is failing. Could you take a look and fix it so all checks pass? Happy to review again once that’s done. |
Replace native bcrypt with bcryptjs to fix Next.js build failure on /api/auth/login page data collection. Re-apply login security changes after merging upstream main per maintainer request. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
fixed |
Contributor
|
Kindly resolve conflict |
Contributor
|
Conflict not yet resolved |
Keep bcrypt login validation, use signToken JWT, fix signup referral imports.
Contributor
Author
|
all conflicts resolved. You can merge now @RUKAYAT-CODER |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #705
Summary
Test plan