Replace replaceState with pushState for search filter changes#821
Merged
Conversation
Search store (src/app/store/searchStore.ts) now calls pushState for significant filter changes (query, difficulty, topics, sort, price, duration, instructors) creating history entries so the Back button restores previous search state. replaceState is retained only for transient pagination cursor updates. A popstate listener restores filter state from URL on back/forward navigation. All 14 tests pass. Closes rinafcode#777
|
@deslawson Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Fixed, all tests should pass now |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Search store (src/app/store/searchStore.ts) now calls pushState for significant filter changes (query, difficulty, topics, sort, price, duration, instructors) creating history entries so the Back button restores previous search state. replaceState is retained only for transient pagination cursor updates. A popstate listener restores filter state from URL on back/forward navigation. All 14 tests pass.
Related Issue
Closes #777
Type of Change
Checklist
Closes #777