fix: gate Sentry init on EXPO_PUBLIC_SENTRY_ENABLED instead of isDev#747
Merged
RUKAYAT-CODER merged 1 commit intoJun 30, 2026
Conversation
d874262 to
f6c1613
Compare
|
@collinsezedike Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Closes #639.
initializeLogging()previously calledSentry.init()only when!isDev. BecauseisDevis derived from__DEV__at module load time, staging and internal testing builds compiled with__DEV__ === true(e.g. EAS preview distributed internally) would silently discard all exceptions - never reaching the QA team's Sentry project.This PR decouples Sentry initialization from the dev/prod binary and puts it under an explicit
EXPO_PUBLIC_SENTRY_ENABLEDenv var:EXPO_PUBLIC_SENTRY_ENABLED=true: Sentry initializes,environmenttag set to'staging'so events are filtered correctly in the Sentry dashboardenvironmenttag set to'production'isDevis left in place - it still controls log level and verbosity. Only the Sentry init decision is moved toisSentryEnabled.Changes
src/config/logging.tsisSentryEnabledconstant; replacedif (!isDev)guard withif (isSentryEnabled); Sentryenvironmentnow reflects'staging'vs'production'src/config/env.tsEXPO_PUBLIC_SENTRY_ENABLEDtoEnvConfigtype and validationeas.jsondevelopmentprofile setsEXPO_PUBLIC_SENTRY_ENABLED=false;previewandproductionprofiles set it totruedocs/environments.mdsrc/__tests__/config/logging.test.tstrue(on, staging env), production without var (on, production env), production withfalse(still on), dev withfalse(off)