Skip to content

Capture Files changed page fixtures #2

Closed

Description

@ribeirogab

Parent

#1

What to build

A set of sanitized fixtures of GitHub's current Files changed page that the end-to-end tests serve in place of github.com. Signed-out visitors get the classic page, so a person with a GitHub session must capture them.

Create a demo pull request that mirrors the design prototype's demo (22 files: tests, lockfiles, generated files, docs, a renamed file, a deleted file, and a review comment on a test file), then save the pages and the responses that the tests need to replay a real review session.

Acceptance criteria

  • A demo pull request mirrors the prototype's 22 files and adds a renamed file, a deleted file, a path that contains a space, and a review comment on a test file.
  • Fixtures exist for the Files changed page of the demo pull request, a single-commit view, a commit-range view, the classic Files changed page, a large pull request in single file mode, and a pull request large enough to load files incrementally or virtualize the diff.
  • The fixtures include the responses that GitHub loads after the first render (more files, route changes), so the tests can replay them.
  • Personal data, tokens, and session values are removed from every fixture.
  • A short note explains how to refresh the fixtures and records whether the sidebar tree lists every file before all diff blocks load.

Blocked by

None — can start immediately.

Activity

  1. self-assigned this
    on Oct 2, 2026
  2. ribeirogab commented on Oct 2, 2026

    @ribeirogab
    OwnerAuthor

    Done in commit 49e302d.

    • Demo repository: https://github.com/ribeirogab/github-file-hider-demo (PR 1: 25 files, PR 2: 800 files, PR 3: about 150,000 lines).
    • 10 sanitized fixtures in tests/fixtures/github/: Files changed, single commit, commit range, Conversation, classic page, the 800-file pull request before and after scrolling, the optimized large view, and single file mode before and after J.
    • Capture and refresh: scripts/capture-fixture.js plus pnpm fixtures:sanitize. The README in the fixtures folder explains the steps.
    • The sidebar tree lists every file before the diffs render.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ready-for-humanNeeds a person; an agent cannot do it

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions