feat!: declare models by overriding accessors, not by dunder

.check_expression_baseline.json

@@ -0,0 +1,213 @@
+{
+  "entries": {
+    "0278ac9b2d99f243": 2,
+    "1182e6a5168fad4d": 2,
+    "15d8c1ad5f05215a": 3,
+    "2207e5f45a158db2": 1,
+    "25138787f4f3c292": 1,
+    "26f48745c86bcb6c": 3,
+    "3a76dbbb69039561": 1,
+    "481c9c33d29a2930": 1,
+    "4a00de96e7c111a8": 1,
+    "687f736f87568fa7": 1,
+    "6881e297193f53fb": 2,
+    "9cede0bc2031de72": 1,
+    "a316d4185f6c5372": 1,
+    "adbe0ad37f3fd6c9": 1,
+    "aebaaac3f9ed8118": 1,
+    "cc38ae350540075e": 1,
+    "d55e960506f63189": 1,
+    "df7098df4eaf8eba": 1,
+    "e6738eb70915f158": 1,
+    "e775979689c0aa90": 2,
+    "ee65f2c95cb20172": 2,
+    "f0868da2f55f9884": 1,
+    "f27dd66925c1fb96": 1,
+    "fabe6126b76a1058": 1,
+    "fad924c61e4a2756": 1,
+    "fc1ce8dd882c87df": 2
+  },
+  "findings": [
+    {
+      "found": "sparse: Optional[bool]",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/expression/column.py",
+      "rule": "ED-10.2"
+    },
+    {
+      "found": "rowguidcol: Optional[bool]",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/expression/column.py",
+      "rule": "ED-10.2"
+    },
+    {
+      "found": "sparse: Optional[bool]",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/expression/column.py",
+      "rule": "ED-10.2"
+    },
+    {
+      "found": "rowguidcol: Optional[bool]",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/expression/column.py",
+      "rule": "ED-10.2"
+    },
+    {
+      "found": "slots",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/expression/objects.py",
+      "rule": "ED-KWARGS"
+    },
+    {
+      "found": "getattr(expr, \"cascade\", False)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/ddl_type.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"restrict\", False)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/ddl_type.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, 'definition_kind', type(expr).__name__)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/ddl_type.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, 'definition_kind', type(expr).__name__)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/ddl_type.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, 'action_kind', type(expr).__name__)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/ddl_type.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr.options, \"schemabinding\", False)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/ddl_view.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(clause, \"with_ties\", False)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/dql.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"partition_scheme\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/partition.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"select_into_table\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/protocol_support.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"or_alter\", False)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/routine.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"schema\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/routine.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"parameters\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/routine.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"body\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/routine.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"returns\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/routine.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"or_alter\", False)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/routine.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"schema\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/routine.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"parameters\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/routine.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"body\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/routine.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"kind\", \"PROCEDURE\")",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/routine.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"if_exists\", False)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/routine.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"schema\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/routine.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"table_name\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/trigger.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"table\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/trigger.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"timing\", \"AFTER\")",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/trigger.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"events\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/trigger.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"body\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/trigger.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"or_alter\", False)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/trigger.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"schema\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/trigger.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"schema\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/trigger.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"if_exists\", False)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/trigger.py",
+      "rule": "ED-11.2"
+    },
+    {
+      "found": "getattr(expr, \"schema\", None)",
+      "path": "src/rhosocial/activerecord/backend/impl/sqlserver/mixins/trigger.py",
+      "rule": "ED-11.2"
+    }
+  ],
+  "format": 1
+}

.github/workflows/test.yml

@@ -54,8 +54,8 @@ jobs:
 
     - name: Install activerecord and testsuite from PyPI
       run: |
-        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@feature/error-taxonomy"  # NOSONAR
-        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@feature/error-taxonomy"  # NOSONAR
+        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@release/v1.0.0.dev30"  # NOSONAR
+        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@release/v1.0.0.dev17"  # NOSONAR
 
     - name: Install dependencies
       run: |
@@ -144,8 +144,8 @@ jobs:
 
     - name: Install activerecord and testsuite from PyPI
       run: |
-        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@feature/error-taxonomy"  # NOSONAR
-        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@feature/error-taxonomy"  # NOSONAR
+        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@release/v1.0.0.dev30"  # NOSONAR
+        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@release/v1.0.0.dev17"  # NOSONAR
 
     - name: Install dependencies
       run: |
@@ -234,8 +234,8 @@ jobs:
 
     - name: Install activerecord and testsuite from PyPI
       run: |
-        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@feature/error-taxonomy"  # NOSONAR
-        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@feature/error-taxonomy"  # NOSONAR
+        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@release/v1.0.0.dev30"  # NOSONAR
+        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@release/v1.0.0.dev17"  # NOSONAR
 
     - name: Install dependencies
       run: |
@@ -324,8 +324,8 @@ jobs:
 
     - name: Install activerecord and testsuite from PyPI
       run: |
-        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@feature/error-taxonomy"  # NOSONAR
-        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@feature/error-taxonomy"  # NOSONAR
+        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@release/v1.0.0.dev30"  # NOSONAR
+        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@release/v1.0.0.dev17"  # NOSONAR
 
     - name: Install dependencies
       run: |
@@ -414,8 +414,8 @@ jobs:
 
     - name: Install activerecord and testsuite from PyPI
       run: |
-        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@feature/error-taxonomy"  # NOSONAR
-        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@feature/error-taxonomy"  # NOSONAR
+        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@release/v1.0.0.dev30"  # NOSONAR
+        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@release/v1.0.0.dev17"  # NOSONAR
 
     - name: Install dependencies
       run: |
@@ -504,8 +504,8 @@ jobs:
 
     - name: Install activerecord and testsuite from PyPI
       run: |
-        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@feature/error-taxonomy"  # NOSONAR
-        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@feature/error-taxonomy"  # NOSONAR
+        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@release/v1.0.0.dev30"  # NOSONAR
+        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@release/v1.0.0.dev17"  # NOSONAR
 
     - name: Install dependencies
       run: |
@@ -595,8 +595,8 @@ jobs:
 
     - name: Install activerecord and testsuite from PyPI
       run: |
-        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@feature/error-taxonomy"  # NOSONAR
-        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@feature/error-taxonomy"  # NOSONAR
+        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@release/v1.0.0.dev30"  # NOSONAR
+        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@release/v1.0.0.dev17"  # NOSONAR
 
     - name: Install dependencies
       run: |
@@ -685,8 +685,8 @@ jobs:
 
     - name: Install activerecord and testsuite from PyPI
       run: |
-        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@feature/error-taxonomy"  # NOSONAR
-        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@feature/error-taxonomy"  # NOSONAR
+        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@release/v1.0.0.dev30"  # NOSONAR
+        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@release/v1.0.0.dev17"  # NOSONAR
 
     - name: Install dependencies
       run: |
@@ -784,8 +784,8 @@ jobs:
 
     - name: Install activerecord and testsuite from PyPI
       run: |
-        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@feature/error-taxonomy"  # NOSONAR
-        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@feature/error-taxonomy"  # NOSONAR
+        pip install "rhosocial-activerecord @ git+https://github.com/rhosocial/python-activerecord.git@release/v1.0.0.dev30"  # NOSONAR
+        pip install "rhosocial-activerecord-testsuite @ git+https://github.com/rhosocial/python-activerecord-testsuite.git@release/v1.0.0.dev17"  # NOSONAR
 
     - name: Install dependencies
       run: |

tests/providers/basic_connection.py

@@ -9,7 +9,6 @@
 
 from rhosocial.activerecord.model import ActiveRecord, AsyncActiveRecord
 from rhosocial.activerecord.backend.impl.sqlserver.backend import SQLServerBackend
-from rhosocial.activerecord.backend.impl.sqlserver.config import SQLServerConnectionConfig
 from rhosocial.activerecord.connection.pool import BackendPool, AsyncBackendPool, PoolConfig
 from rhosocial.activerecord.backend.options import ExecutionOptions
 from rhosocial.activerecord.backend.schema import StatementType
@@ -20,15 +19,21 @@
 
 class SyncTestUser(ActiveRecord):
     """Sync test user model for connection pool tests."""
-    __table_name__ = "test_users"
+    @classmethod
+    def table_name(cls):
+        return "test_users"
+
     id: Optional[int] = None
     name: str
     email: str
 
 
 class AsyncTestUser(AsyncActiveRecord):
     """Async test user model for connection pool tests."""
-    __table_name__ = "test_users"
+    @classmethod
+    def table_name(cls):
+        return "test_users"
+
     id: Optional[int] = None
     name: str
     email: str

tests/providers/query_connection.py

@@ -9,7 +9,6 @@
 
 from rhosocial.activerecord.model import ActiveRecord, AsyncActiveRecord
 from rhosocial.activerecord.backend.impl.sqlserver.backend import SQLServerBackend
-from rhosocial.activerecord.backend.impl.sqlserver.config import SQLServerConnectionConfig
 from rhosocial.activerecord.connection.pool import BackendPool, AsyncBackendPool, PoolConfig
 from rhosocial.activerecord.backend.options import ExecutionOptions
 from rhosocial.activerecord.backend.schema import StatementType
@@ -20,15 +19,21 @@
 
 class SyncQueryTestUser(ActiveRecord):
     """Sync test user model for query connection pool tests."""
-    __table_name__ = "test_users"
+    @classmethod
+    def table_name(cls):
+        return "test_users"
+
     id: Optional[int] = None
     name: str
     email: str
 
 
 class AsyncQueryTestUser(AsyncActiveRecord):
     """Async test user model for query connection pool tests."""
-    __table_name__ = "test_users"
+    @classmethod
+    def table_name(cls):
+        return "test_users"
+
     id: Optional[int] = None
     name: str
     email: str