Repository navigation
feat(errors): classify Snowflake driver errors by taxonomy - #12
Merged
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v1.0.0.dev2 #12 +/- ##
=======================================================
+ Coverage 80.92% 80.96% +0.04%
=======================================================
Files 118 118
Lines 5694 5733 +39
Branches 829 841 +12
=======================================================
+ Hits 4608 4642 +34
- Misses 838 840 +2
- Partials 248 251 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR aligns python-activerecord-snowflake with the new semantic error taxonomy and execute-phase contract:
IntegrityError, login to non-transientConnectionError, timeouts/service failures to transientOperationalError, syntax/unknown identifiers toQueryError, permission denials to non-transientDatabaseError.LockError/DeadlockErroris invented.Adds # (no issue)
Type of change
feat: A new featuretest: Adding missing tests or correcting existing tests (for the new feature)docs: Documentation only changes (if related to the new feature)perf: A code change that improves performance (if part of the feature)chore: Changes to the build process or auxiliary tools and libraries suchs as documentation generation (if related to the new feature)ci: Changes to our CI configuration files and scripts (if related to the new feature)build: Changes that affect the build system or external dependencies (if related to the new feature)revert: Reverts a previous commitBreaking Change
Impact on End-Users:
No backward-incompatible changes: concrete error classes keep their names, and every error remains a
DatabaseError. Behavioural change: auto-commit failures now raiseTransactionErrorinstead of being logged and ignored, and transient connection retries now actually run.Impact on Backend Developers (Custom Implementations):
No signature changes. Custom
_handle_errorimplementations should raise taxonomy errors; the core pipeline adds a defensive fallback when a handler returns.Related Repositories/Packages
python-activerecordPR #139.python-activerecord-testsuitePR (taxonomy contract).feature/error-taxonomyfor both core and testsuite, and will be restored to release branches after the merge.Testing
Test Plan:
Local contract suites: 49 passed. Feature-branch CI run 42973514422: success.
Reproduction:
PYTHONPATH=src:tests pytest tests -k 'test_execute_error_contract or test_driver_error_mapping or test_error_taxonomy_contract'Checklist
README.md, etc.).changelog.d/<issue_number>.<type>.md).Additional Notes
changelog.d/<PR>.added.mdonce the PR number exists, because the checker requires the fragment number to equal the PR number.feature/error-taxonomy; restore release pins after this PR and the core PR merge.