Repository navigation
feat(snowflake): add routines, sequences and catalog-object introspection - #10
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v1.0.0.dev2 #10 +/- ##
=======================================================
+ Coverage 80.96% 81.71% +0.75%
=======================================================
Files 117 117
Lines 5206 5546 +340
Branches 768 804 +36
=======================================================
+ Hits 4215 4532 +317
- Misses 760 771 +11
- Partials 231 243 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Adds the missing snowflake introspection coverage and aligns the CLI surface with what the backend can actually deliver.
The
ddlintrospection type is no longer advertised for this backend becausesupports_ddl_extraction()is permanently False.introspect ddlis now anargparse usage error (exit 2); the backend DDL expression/formatter remains for
a future implementation.
Adds # (no linked issue; operator-directed introspection coverage work)
Type of change
feat: A new featuredocs: Documentation only changestest: Adding missing tests or correcting existing testsci: Changes to CI configuration files and scriptsperfchorebuildrevertBreaking Change
The removed
ddlCLI type never produced an answer for an ordinary table, soits removal changes the help/type surface rather than a working capability.
Applicable
rhosocial-activerecordVersion Range:>=1.0.0.dev30,<2.0.0Related Repositories/Packages
rhosocial-activerecordcore:release/v1.0.0.dev30rhosocial-activerecord-testsuite:release/v1.0.0.dev17release/v1.0.0.dev2Testing
42592054261: success (all jobs)introspect --helpno longer listsddlintrospect ddlexits 2 withinvalid choiceTest Plan:
The CI run above is the full matrix. Targeted offline suites cover the new
formatters, parsers, sync/async dispatch, capability gates and CLI vocabulary.
Checklist
changelog.d/<pr_number>.<type>.md).Not added: the operator explicitly requested no changelog fragments.
Additional Notes
The backend capability/formatter for DDL extraction is intentionally left in
place; only the CLI type was removed until a real implementation exists.
Branch Commits