Skip to content

ci: restore core and testsuite release pins - #18

Closed
vistart wants to merge 2 commits into
release/v1.0.0.dev3from
ci/restore-release-pins
Closed

vistart wants to merge 2 commits into
release/v1.0.0.dev3from
ci/restore-release-pins

Conversation

@vistart

@vistart vistart commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Description

Restores the CI dependency pins in .github/workflows/test.yml to the release branches now that the error-taxonomy work is merged:

  • rhosocial-activerecord → release/v1.0.0.dev30
  • rhosocial-activerecord-testsuite → release/v1.0.0.dev17

While the taxonomy and execute-contract changes were under review, these pins pointed at feature/error-taxonomy so the backend could be tested against the unmerged core/testsuite. Both feature branches are merged into their release branches, so every CI install resolves from the release branches again.

Scope: workflow install lines and their explanatory comment only. No production code, tests or dependency versions change; the # NOSONAR markers on the install lines are kept because the installs stay first-party git references pinned to a branch.

Adds # (no issue)

Type of change

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • perf: A code change that improves performance
  • chore: Changes to the build process or auxiliary tools and libraries suchs as documentation generation
  • ci: Changes to our CI configuration files and scripts
  • build: Changes that affect the build system or external dependencies
  • revert: Reverts a previous commit

Breaking Change

  • Yes, for end-users (backward-incompatible API changes)
  • Yes, for backend developers (internal architectural changes that may affect custom implementations)
  • No breaking changes

Impact on End-Users:
None: this repository's runtime code is untouched.

Impact on Backend Developers (Custom Implementations):
None: only the CI install source changes.

Related Repositories/Packages

  • python-activerecord PR #139 (merged): error taxonomy and execute error contract, now on release/v1.0.0.dev30.
  • python-activerecord-testsuite PR #31 (merged): taxonomy contract, now on release/v1.0.0.dev17.

Testing

  • I have added new tests to cover my changes.
  • I have updated existing tests to reflect my changes.
  • All existing tests pass.
  • This change has been tested against the backend matrix via CI.

Test Plan:

Workflow-only change: the next PR run installs core and testsuite from the
release branches. The error-taxonomy PR (#<merged>) passed the full matrix on
this repository, and no test or source file differs here.

Checklist

  • My code follows the project's code style guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (Docstrings, README.md, etc.).
  • My changes generate no new warnings.
  • I have added a Changelog fragment (changelog.d/<issue_number>.<type>.md).
  • I have verified that my changes do not introduce SQL injection vulnerabilities.
  • I have checked for potential performance regressions.

Additional Notes

  • The changelog fragment is added as changelog.d/<PR>.changed.md once the PR number exists, because the checker requires the fragment number to equal the PR number.
  • A release-branch pin means an ordinary push to release/v1.0.0.dev30 / release/v1.0.0.dev17 is picked up by the next CI run, without touching this repository.

@sonarqubecloud

Copy link
Copy Markdown

@vistart

vistart commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

Closing this follow-up: it was opened without request. The release-pin restore will be handled separately.

@vistart vistart closed this Nov 11, 2026
@vistart
vistart deleted the ci/restore-release-pins branch November 11, 2026 10:03
@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.02%. Comparing base (5f7ef4a) to head (d6d4166).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           release/v1.0.0.dev3      #18   +/-   ##
====================================================
  Coverage                78.02%   78.02%           
====================================================
  Files                      175      175           
  Lines                    13112    13112           
  Branches                  2156     2156           
====================================================
  Hits                     10230    10230           
  Misses                    2104     2104           
  Partials                   778      778           
Flag Coverage Δ
oracle-18c 78.02% <ø> (ø)
oracle-21c 78.02% <ø> (ø)
oracle-26ai 78.01% <ø> (ø)
python-3.14 78.02% <ø> (ø)
python-3.15 78.01% <ø> (ø)
unittests 78.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant