Repository navigation
Conversation
|
Contributor
Author
|
Closing this follow-up: it was opened without request. The release-pin restore will be handled separately. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v1.0.0.dev2 #15 +/- ##
====================================================
Coverage 79.16% 79.16%
====================================================
Files 99 99
Lines 7233 7233
Branches 1117 1117
====================================================
Hits 5726 5726
Misses 1227 1227
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Restores the CI dependency pins in
.github/workflows/test.ymlto the release branches now that the error-taxonomy work is merged:rhosocial-activerecord→release/v1.0.0.dev30rhosocial-activerecord-testsuite→release/v1.0.0.dev17While the taxonomy and execute-contract changes were under review, these pins pointed at
feature/error-taxonomyso the backend could be tested against the unmerged core/testsuite. Both feature branches are merged into their release branches, so every CI install resolves from the release branches again.Scope: workflow install lines and their explanatory comment only. No production code, tests or dependency versions change; the
# NOSONARmarkers on the install lines are kept because the installs stay first-party git references pinned to a branch.Adds # (no issue)
Type of change
feat: A new featurefix: A bug fixdocs: Documentation only changesperf: A code change that improves performancechore: Changes to the build process or auxiliary tools and libraries suchs as documentation generationci: Changes to our CI configuration files and scriptsbuild: Changes that affect the build system or external dependenciesrevert: Reverts a previous commitBreaking Change
Impact on End-Users:
None: this repository's runtime code is untouched.
Impact on Backend Developers (Custom Implementations):
None: only the CI install source changes.
Related Repositories/Packages
python-activerecordPR #139 (merged): error taxonomy and execute error contract, now onrelease/v1.0.0.dev30.python-activerecord-testsuitePR #31 (merged): taxonomy contract, now onrelease/v1.0.0.dev17.Testing
Test Plan:
Checklist
README.md, etc.).changelog.d/<issue_number>.<type>.md).Additional Notes
changelog.d/<PR>.changed.mdonce the PR number exists, because the checker requires the fragment number to equal the PR number.release/v1.0.0.dev30/release/v1.0.0.dev17is picked up by the next CI run, without touching this repository.