Repository navigation
feat(errors): classify BigQuery driver errors by taxonomy - #10
Merged
Merged
Conversation
Recognition now reads the google.api_core exception class and HTTP status before message text, and annotates every translated error with operation, driver_code, backend and transient diagnostics. Mapping: AlreadyExists/409 and BadRequest/InvalidArgument/FailedPrecondition naming a constraint -> IntegrityError; NotFound/404 and other 4xx -> QueryError; Forbidden/Unauthorized/401/403 -> DatabaseError with transient=False; TooManyRequests/ResourceExhausted 429, ServiceUnavailable 503, DeadlineExceeded/GatewayTimeout 504 and InternalServerError 500/502 -> OperationalError(transient=True); socket/requests/google-auth transport failures -> ConnectionError(transient=True); anything else -> DatabaseError. BigQuery has no deadlock or lock-wait concept: 409 Aborted maps to a transient OperationalError and this backend never raises LockError/DeadlockError. The sync and async backends share one translator, and the emulator REST fast path now raises the status-specific class so 429/503/504 keep their transient mapping. Adds driver-mapping unit tests (synthetic api_core exceptions, no service) and the testsuite taxonomy contract wrapper.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/v1.0.0.dev1 #10 +/- ##
=======================================================
+ Coverage 82.48% 84.02% +1.54%
=======================================================
Files 44 44
Lines 3225 3274 +49
Branches 421 431 +10
=======================================================
+ Hits 2660 2751 +91
+ Misses 448 411 -37
+ Partials 117 112 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns python-activerecord-bigquery with the new semantic error taxonomy and execute-phase contract:
IntegrityError, 401/403 to non-retryableDatabaseError, 404/400 toQueryError, 429/503/504/5xx to transientOperationalError, transport failures to transientConnectionError.job.errorswithout a driver exception now goes through the message classifier with diagnostics.Adds # (no issue)
Type of change
feat: A new featuretest: Adding missing tests or correcting existing tests (for the new feature)docs: Documentation only changes (if related to the new feature)perf: A code change that improves performance (if part of the feature)chore: Changes to the build process or auxiliary tools and libraries suchs as documentation generation (if related to the new feature)ci: Changes to our CI configuration files and scripts (if related to the new feature)build: Changes that affect the build system or external dependencies (if related to the new feature)revert: Reverts a previous commitBreaking Change
Impact on End-Users:
No backward-incompatible changes: concrete error classes keep their names, and every error remains a
DatabaseError. Behavioural change: auto-commit failures now raiseTransactionErrorinstead of being logged and ignored, and transient connection retries now actually run.Impact on Backend Developers (Custom Implementations):
No signature changes. Custom
_handle_errorimplementations should raise taxonomy errors; the core pipeline adds a defensive fallback when a handler returns.Related Repositories/Packages
python-activerecordPR #139.python-activerecord-testsuitePR (taxonomy contract).feature/error-taxonomyfor both core and testsuite, and will be restored to release branches after the merge.Testing
Test Plan:
Local contract suites: 82 passed. Feature-branch CI run 42973525483: success.
Reproduction:
PYTHONPATH=src:tests pytest tests -k 'test_execute_error_contract or test_driver_error_mapping or test_error_taxonomy_contract'Checklist
README.md, etc.).changelog.d/<issue_number>.<type>.md).Additional Notes
changelog.d/<PR>.added.mdonce the PR number exists, because the checker requires the fragment number to equal the PR number.feature/error-taxonomy; restore release pins after this PR and the core PR merge.