Repository navigation
Correct sponsorship annual value docs for ended contracts - #24
Merged
Merged
Conversation
The docs said an ended contract's annual value is zero, but ended contracts often keep a non-zero annual value. Describe annual_value as what a running contract pays a year and point readers at end to tell running contracts from ended ones. Refs #11. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sponsorship.annual_valuedocs said an ended contract's annual value is 0. It often isn't, and can equal the total value, so the docs now say to compareendwith the save's date to find running contracts.total_valueno longer claims a fixed share of contracts where total equals annual times years.Refs #11
Checklist
uv run pytest,uv run ruff check .,uv run ruff format --check .anduv run pyrightpass.🤖 Generated with Claude Code