Repository navigation
Stop finance readers borrowing data from skipped club records; release 0.5.10 - #23
Merged
Merged
Conversation
…e 0.5.10 The club scan skips some club records, such as clubs playing in another nation's league. Each accepted club's span ran to the next accepted record, so a skipped record's finance series, sponsors and facilities were read as the earlier club's. On the issue #20 save, 2 clubs then held 2 finance chains and finances() failed. Finances, sponsorships and facilities now end each span at the next record header, accepted or not: a zero byte followed by 2 printable, length-prefixed names, whose club index the scan did not accept. The club index and every other reader keep their spans unchanged. The header search costs 1 to 3 s per save and runs once, only for those 3 readers. Across 48 local saves, 15 lose rows that belonged to skipped records, no rows are added, no other reader changes and the Lens save's finances pass. Refs #20. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finances(),sponsorships()andfacilities()now end each club's span at the next record header, accepted or not. The club index,clubs(), staff and every other reader keep their spans unchanged.Refs #20
Verification
finances()goes from failed (finance_clubs_with_two_chains= 2) to ok.main.ruff,pyright, unit tests and local corpus tests pass.🤖 Generated with Claude Code