Repository navigation
Read long careers with national teams and flagged name pools; release 0.5.9 - #22
Merged
Merged
Conversation
… 0.5.9 A 26.3.2 career save failed 19 of 27 readers. Four general causes: - The name-pool header stores nonzero values in a 4-byte field most saves leave at zero. Those bytes are no longer compared; every other header byte, each pool entry and the uniqueness check still are. - The stage table sat 34.2 MB from the end of game_db, past the 32 MiB search cap that had already been raised as careers grew. The search now doubles to the start of the section, and the stage gates judge the rows. - The manager also runs national teams, whose tactic blocks the header counts. Tactics validation compares the header with the blocks found by structure, and each club block ends at the next stored block. - Generated players with object kind 3 and generated staff with ability codes outside the observed set are read instead of dropped. Refs #20. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 26.3.2 career save from #20 failed 19 of its 27 readers, starting with "name pools not found". The save had 4 separate causes, and each fix is general rather than tuned to that save:
game_db, past the 32 MiB search cap that earlier careers had already pushed up twice. The search now doubles to the start of the section, and the stage gates judge the rows it finds.non_club_blocks.Prepares patch release 0.5.9. Refs #20.
Validation: the full suite passes (2,944 tests), plus the 43 corpus tests. Lint, formatting, type checks, the docs build, the distribution check, and a wheel smoke test pass. A sweep of all 48 local saves on
mainand this branch, 1 save at a time with the network denied and checksums compared before and after, shows the #20 save going from 8 to 26 passing readers. No reader result or row count changed on the other 47. Every remaining failure is also onmain; the #20 save's finances failure is a separate club-span bug that gets its own PR.The change contains no save files, fragments, screenshots, or real player data. No decompilation, leaked material, or unlicensed parser code was used.
🤖 Generated with Claude Code