Skip to content

Make sure circles and squares have the same area#5

Open
arrufat wants to merge 2 commits into
rexim:mainfrom
arrufat:patch-1
Open

Make sure circles and squares have the same area#5
arrufat wants to merge 2 commits into
rexim:mainfrom
arrufat:patch-1

Conversation

@arrufat

@arrufat arrufat commented Apr 6, 2025

Copy link
Copy Markdown

When just changing the radius, the circles look a bit small. This PR makes the area of all shapes constant for visual harmony.

When just changing the radius, the circles look a bit small.
This PR makes the area of all shapes constant for visual harmony.
@jeezrick

jeezrick commented Apr 7, 2025

Copy link
Copy Markdown

Is scale(1) unnecessary here?BTW, cool change.

li:has(a:active)::before,
.logo:active,
body:has(.logo:active) li::before {
    background: #f43841;
    border-radius: 0%;
    transform: rotate(45deg) scale(1);
}

@ZYR0Z

ZYR0Z commented Apr 8, 2025

Copy link
Copy Markdown

Maybe it would also be nice to replace the literal beginnings of pi, with just the pi keyword, as this is now widely supported (MDN Calc-Keyword)

@arrufat

arrufat commented Apr 8, 2025

Copy link
Copy Markdown
Author

@jeezrick right, this was a left over of my trials...
@ZYR0Z I've replaced the pi literal with the keyword, didn't know that was supported.
Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants