Skip to content

test(domains): pass click and open tracking params in create test#171

Merged
drish merged 1 commit intofeat/tracking-caa-recordfrom
feat/domain-create-tracking-options
Apr 16, 2026
Merged

test(domains): pass click and open tracking params in create test#171
drish merged 1 commit intofeat/tracking-caa-recordfrom
feat/domain-create-tracking-options

Conversation

@rehanvdm
Copy link
Copy Markdown
Contributor

@rehanvdm rehanvdm commented Apr 16, 2026

Summary

  • Update domain creation test to also pass click_tracking and open_tracking in the create params, reflecting the API's support for these on create
  • No code changes needed — Ruby's untyped hash params already pass through to the API

Test plan

  • Verified Ruby syntax with ruby -c
  • Run bundle exec rspec spec/domains_spec.rb

🤖 Generated with Claude Code


Summary by cubic

Update the domain creation test to pass click_tracking and open_tracking in the create params, matching the API’s create support and ensuring these flags are covered. No production code changes; the params already pass through to the API.

Written for commit 1152e7b. Summary will update on new commits.

Update the domain creation test to also pass click_tracking and
open_tracking, reflecting the API's support for these on create.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@drish drish merged commit 6b01399 into feat/tracking-caa-record Apr 16, 2026
5 checks passed
@drish drish deleted the feat/domain-create-tracking-options branch April 16, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants