test(domains): pass click and open tracking params in create test#171
Merged
drish merged 1 commit intofeat/tracking-caa-recordfrom Apr 16, 2026
Merged
Conversation
Update the domain creation test to also pass click_tracking and open_tracking, reflecting the API's support for these on create. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
drish
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
click_trackingandopen_trackingin the create params, reflecting the API's support for these on createTest plan
ruby -cbundle exec rspec spec/domains_spec.rb🤖 Generated with Claude Code
Summary by cubic
Update the domain creation test to pass
click_trackingandopen_trackingin the create params, matching the API’s create support and ensuring these flags are covered. No production code changes; the params already pass through to the API.Written for commit 1152e7b. Summary will update on new commits.