fix: warn and confirm when optional pickId fetch fails#229
Draft
bukinoshita wants to merge 2 commits intomainfrom
Draft
fix: warn and confirm when optional pickId fetch fails#229bukinoshita wants to merge 2 commits intomainfrom
bukinoshita wants to merge 2 commits intomainfrom
Conversation
Previously, when pickId was called in optional mode and the fetch failed, it silently returned undefined. This caused callers like api-keys create to proceed without domain scoping, creating broader-than-intended API keys. Now, when a fetch fails in optional mode, the user sees a warning with the error message and must explicitly confirm continuing without scope. Declining or cancelling the confirmation aborts the operation. Fixes BU-614 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Warns and requires explicit confirmation when
pickId(optional mode) fails to load items, preventing silent scope drops. Prevents unscoped API keys or topic-less broadcasts when fetches fail.Written for commit fbe1e52. Summary will update on new commits.