[glennsl]

Add missing handlers and capture variants through React DOM 19.3.1, including dialog, fullscreen, toggle, auxiliary-click, resize, scroll-end, and transition lifecycle events.

Add JsxEvent.Toggle with typed oldState, newState, and optional source accessors. Include JSX regression coverage and updated editor-completion snapshots.

Sources:

• DOMEventProperties.js: handler names and registration.
• EventRegistry.js: capture variants.
• SimpleEventPlugin.js: event types.
• SyntheticEvent.js: toggle fields.
• MDN: oldState, newState, and source.

[github-actions]

Changelog

💅 Polish

• Add missing JSX DOM event handlers and capture variants through React 19.3, including dialog, fullscreen, toggle, scroll-end, and transition events, with typed toggle states and source.

Semantic Diff

1 commit · Full page

✏️ Add missing JSX DOM event bindings

_{3f55f1e · glennsl · Oct 27, 2026, 12:39 UTC · edited}

Why

React DOM event handlers are missing from JsxDOM.domProps, forcing local extensions for dialogs, popovers, fullscreen, and capture-phase events. Match the event registrations and toggle fields in React DOM 19.3.1.

Typing modified (JsxDOM.domProps)

rescript · Before: Representative existing handlers · After: Existing handlers remain; missing handlers and capture variants are added

+onCancel?: JsxEvent.Synthetic.t => unit,
+onCancelCapture?: JsxEvent.Synthetic.t => unit,
+onClose?: JsxEvent.Synthetic.t => unit,
+onCloseCapture?: JsxEvent.Synthetic.t => unit,
+onFullscreenChange?: JsxEvent.Synthetic.t => unit,
+onFullscreenChangeCapture?: JsxEvent.Synthetic.t => unit,
+onFullscreenError?: JsxEvent.Synthetic.t => unit,
+onFullscreenErrorCapture?: JsxEvent.Synthetic.t => unit,
+onBeforeToggle?: JsxEvent.Toggle.t => unit,
+onBeforeToggleCapture?: JsxEvent.Toggle.t => unit,
+onToggle?: JsxEvent.Toggle.t => unit,
+onToggleCapture?: JsxEvent.Toggle.t => unit,
 onClick?: JsxEvent.Mouse.t => unit,
+onClickCapture?: JsxEvent.Mouse.t => unit,
 onScroll?: JsxEvent.UI.t => unit,
+onScrollCapture?: JsxEvent.UI.t => unit,
+onScrollEnd?: JsxEvent.UI.t => unit,
+onScrollEndCapture?: JsxEvent.UI.t => unit,
 onTransitionEnd?: JsxEvent.Transition.t => unit,
+onTransitionEndCapture?: JsxEvent.Transition.t => unit,
+… auxiliary-click, resize, transition cancel/run/start, and remaining capture handlers

Typing added (JsxEvent.Toggle)

rescript · After

module Toggle = {
  type tag
  type t = synthetic<tag>
  include MakeEventWithType({type t = t})
  @get external oldState: t => [#closed | #"open"] = "oldState"
  @get external newState: t => [#closed | #"open"] = "newState"
  @get @return(nullable) external source: t => option<Dom.element> = "source"
}

The JSX fixture covers the added handlers and toggle accessors. The editor completion snapshot is regenerated against the rebased compiler.

Review

• Does this require React 19.3 for existing applications? No existing signatures change. Fullscreen handlers and the synthetic toggle source are available in React 19.3. The source accessor returns None for null or undefined, including on older React versions.
• Are enter/leave capture handlers included? No. React's mouse and pointer enter/leave events have no capture phase.

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@9075

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@9075

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@9075

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@9075

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@9075

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@9075

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@9075

commit: 3f55f1e

[cknitt]

@glennsl Thanks a lot, this is great!

Could you rebase on latest master, and ask your agent to fill out the commit records for semantic diff using the records skill as described in AGENTS.md?