Skip to content

Test the evaluation order of a dict spread with children in JSX preserve mode #9057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cknitt merged 1 commit into from
Oct 26, 2026
Merged

Test the evaluation order of a dict spread with children in JSX preserve mode #9057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/build_tests/jsx_preserve_semantics/cases/Order.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,14 @@ let copySpreadOrder = log->Array.copy

let props = <Logged a={note("a")} b={note("b")} />
let propsOrder = log->Array.copy

module LoggedDict = {
@val external make: React.component<dict<string>> = "LoggedComp"
}

// A dict spread is one props object: its children are evaluated before the
// fields after them
let dictBase: dict<string> = dict{}
let dictChildren =
<LoggedDict {...dict{...dictBase, "children": note("children"), "title": note("title")}} />
let dictChildrenOrder = log->Array.copy
Loading