Repository navigation
Remove the converted Reason project corpus from the syntax tests - #9012
Conversation
Constructs only the corpus covered are now printer fixtures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UoDHhLCpoQeKvfN6VbVcHv Signed-off-by: Christoph Knittel <ck@cca.io>
ChangelogNo changelog entry. Semantic Diff1 commit · Full page |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9012 +/- ##
==========================================
- Coverage 81.31% 81.31% -0.01%
==========================================
Files 456 456
Lines 63979 63979
==========================================
- Hits 52024 52022 -2
- Misses 11955 11957 +2 🚀 New features to boost your workflow:
|
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-9012 |
tests/syntax_tests/data/idempotencyheld about 109k lines of old community projects converted from Reason (bs-css, reason-react, pupilfirst, …). Only the roundtrip run ofscripts/test_syntax.shused it, checking that printing twice gives the same output. Every syntax deprecation or removal had to rewrite it, and its history shows no printer bug it caught.I compared bisect_ppx line coverage of
compiler/syntaxfor the regular syntax tests against a roundtrip of the corpus. The corpus covered 25 lines nothing else did. Each one traces to a construct that now has a minimal snippet in an existing printer fixture:module Events: RGLEvents.t)%rawstring with backslash escapes//comment between a JSX prop name and its valueswitchscrutinee; switch cases with array/tuple/object/record bodiesx->(c ? f : g)(~a))if (switch …)conditionWith these fixtures added, rerunning the comparison finds no line that only the corpus covers.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UoDHhLCpoQeKvfN6VbVcHv