Repository navigation
Run the commit records tests in CI - #8986
Conversation
`yarn test-commit-records` ran nowhere in CI, so a change that broke the record parser or the Markdown comment passed and showed up only as wrong pages and comments on other pull requests. The renderer is platform independent, so the linux-arm64 job runs them. Signed-off-by: Christoph Knittel <ck@cca.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe
Semantic Diff1 commit · Full page Run the commit records tests in CId06edba · Christoph Knittel with Claude Opus 5.5 · Oct 23, 2026
|
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8986 |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Semantic Diff1 new commit (2 total) · Full page Select the commit records CI step with a matrix property64a5bcf · Christoph Knittel with Claude Opus 5.5 · Oct 23, 2026 Like the benchmarks and the playground build, the step is enabled by a property of its matrix entry instead of a condition on the node target. |
Like the benchmarks and the playground build, the step is enabled by a property of its matrix entry instead of a condition on the node target. Signed-off-by: Christoph Knittel <ck@cca.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe
64a5bcf to
890e98b
Compare
Semantic Diff2 commits · Full page Run the commit records tests in CId06edba · Christoph Knittel with Claude Opus 5.5 · Oct 23, 2026
Select the commit records CI step with a matrix property890e98b · Christoph Knittel with Claude Opus 5.5 · Oct 23, 2026 Like the benchmarks and the playground build, the step is enabled by a property of its matrix entry instead of a condition on the node target. |
Fixes #8972.
yarn test-commit-records(scripts/commitRecords.test.jsandscripts/recordMarkdown.test.js) wasn't run by any workflow, Makefile target orscripts/test.jsstep. A pull request that brokeparseRecordor the Markdown comment therefore passed CI, and the breakage showed up only as wrong pages or comments on later pull requests.CI now runs the tests next to "Test release plan". The renderer is platform-independent JavaScript and the tests use only
gitin temporary directories, so one matrix entry runs them: the step is enabled by atest_commit_recordsproperty on the linux-arm64 entry, the same waybenchmarksandbuild_playgroundare. #8962, which adds a test file to the same script, will be covered once it merges.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe