Skip to content

Run the commit records tests in CI - #8986

Merged
cknitt merged 2 commits into
masterfrom
drift-8972-commit-records-ci
Oct 23, 2026
Merged

cknitt merged 2 commits into
masterfrom
drift-8972-commit-records-ci

Conversation

@cknitt

@cknitt cknitt commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Fixes #8972.

yarn test-commit-records (scripts/commitRecords.test.js and scripts/recordMarkdown.test.js) wasn't run by any workflow, Makefile target or scripts/test.js step. A pull request that broke parseRecord or the Markdown comment therefore passed CI, and the breakage showed up only as wrong pages or comments on later pull requests.

CI now runs the tests next to "Test release plan". The renderer is platform-independent JavaScript and the tests use only git in temporary directories, so one matrix entry runs them: the step is enabled by a test_commit_records property on the linux-arm64 entry, the same way benchmarks and build_playground are. #8962, which adds a test file to the same script, will be covered once it merges.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe

`yarn test-commit-records` ran nowhere in CI, so a change that broke the
record parser or the Markdown comment passed and showed up only as wrong
pages and comments on other pull requests. The renderer is platform
independent, so the linux-arm64 job runs them.

Signed-off-by: Christoph Knittel <ck@cca.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe
@github-actions

Copy link
Copy Markdown

Semantic Diff

1 commit · Full page

Run the commit records tests in CI

d06edba · Christoph Knittel with Claude Opus 5.5 · Oct 23, 2026

yarn test-commit-records ran nowhere in CI, so a change that broke the record parser or the Markdown comment passed and showed up only as wrong pages and comments on other pull requests. The renderer is platform independent, so the linux-arm64 job runs them.

@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8986

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@8986

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8986

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8986

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8986

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8986

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8986

commit: 890e98b

@github-actions

Copy link
Copy Markdown

@cknitt
cknitt marked this pull request as ready for review October 23, 2026 09:25
@cknitt

cknitt commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T09:26:41.497320Z d06edba Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: d06edba64b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

Copy link
Copy Markdown

Semantic Diff

1 new commit (2 total) · Full page

Select the commit records CI step with a matrix property

64a5bcf · Christoph Knittel with Claude Opus 5.5 · Oct 23, 2026

Like the benchmarks and the playground build, the step is enabled by a property of its matrix entry instead of a condition on the node target.

Like the benchmarks and the playground build, the step is enabled by a
property of its matrix entry instead of a condition on the node target.

Signed-off-by: Christoph Knittel <ck@cca.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe
@cknitt
cknitt force-pushed the drift-8972-commit-records-ci branch from 64a5bcf to 890e98b Compare October 23, 2026 09:37
@github-actions

Copy link
Copy Markdown

Semantic Diff

2 commits · Full page

Run the commit records tests in CI

d06edba · Christoph Knittel with Claude Opus 5.5 · Oct 23, 2026

yarn test-commit-records ran nowhere in CI, so a change that broke the record parser or the Markdown comment passed and showed up only as wrong pages and comments on other pull requests. The renderer is platform independent, so the linux-arm64 job runs them.

Select the commit records CI step with a matrix property

890e98b · Christoph Knittel with Claude Opus 5.5 · Oct 23, 2026

Like the benchmarks and the playground build, the step is enabled by a property of its matrix entry instead of a condition on the node target.

@cknitt
cknitt requested a review from cristianoc October 23, 2026 09:38
@cknitt
cknitt enabled auto-merge (squash) October 23, 2026 09:38
@cknitt
cknitt merged commit 74f2031 into master Oct 23, 2026
26 checks passed
@cknitt
cknitt deleted the drift-8972-commit-records-ci branch October 23, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

yarn test-commit-records is not run in CI

2 participants