Repository navigation
Mark namespace-entry as requiring namespace in the build schema - #8984
Conversation
The schema said a `namespace-entry` without a namespace has no effect, which describes the Rust build system; `rescript` rejects such a configuration. The description now says so, and a `dependencies` rule lets editors flag a `namespace-entry` without a `namespace` key. Signed-off-by: Christoph Knittel <ck@cca.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe
Semantic Diff1 commit · Full page Mark namespace-entry as requiring namespace in the build schema1728630 · Christoph Knittel with Claude Opus 5.5 · Oct 23, 2026 The schema said a |
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8984 |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17286307ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex review: the property dependency accepted `"namespace": false` with a `namespace-entry`, which `rescript` rejects. The schema dependency now also requires `namespace` not to be `false`. Signed-off-by: Christoph Knittel <ck@cca.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe
Semantic Diff1 new commit (2 total) · Full page Reject namespace false beside namespace-entry in the build schema8717742 · Christoph Knittel with Claude Opus 5.5 · Oct 23, 2026 Codex review: the property dependency accepted |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Fixes #8970.
The schema's
namespace-entrydescription, added in #8835, said "Only has an effect whennamespaceis enabled." That is how the Rust build system behaves.rescript, which is now the OCaml build system, rejects such a configuration on purpose (field "namespace-entry" requires a namespace, listed under the intentional differences inrewatch-ocaml/README.md).The description now says that
namespace-entryrequiresnamespace. A top-level draft-04 schema dependency also requires anamespacethat isn'tfalsewhenevernamespace-entryis set, so editors flag both configurations thatrescriptrejects. Checked with ajv (draft-04) on six combinations: without an entry, everynamespacevalue still validates; with an entry, a missingnamespaceand"namespace": falseare invalid, andtrueor a string is valid. The schema-key tests in both build systems read onlypropertiesanddefinitions, so they are unaffected.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe