Skip to content

Add make test-rewatch-rust for the Rust build system - #8983

Merged
cknitt merged 1 commit into
masterfrom
drift-8969-test-rewatch-docs
Oct 23, 2026
Merged

cknitt merged 1 commit into
masterfrom
drift-8969-test-rewatch-docs

Conversation

@cknitt

@cknitt cknitt commented Oct 23, 2026

Copy link
Copy Markdown
Member

Fixes #8969.

Since #8780, make test-rewatch runs rewatch/tests/suite.sh against rescript.exe, the OCaml build system, and depends only on lib, so it doesn't build rescript-rust. The Rust build system's README and AGENTS.md still gave it as their test command, so following them after changing rewatch/src/*.rs neither rebuilt nor tested the Rust binary.

This adds make test-rewatch-rust, which depends on lib and rewatch and runs the same suite against rescript-rust.exe. That is the command CI runs on linux-arm64. The Rust docs now name the new target and say that make test-rewatch tests the OCaml implementation; the root AGENTS.md lists both. test-all is unchanged.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe

The Rust build system's docs gave `make test-rewatch` as its test command,
but since #8780 that target runs the suite against the OCaml `rescript` and
does not build `rescript-rust`. The new target builds the Rust binary and
runs the suite against it, and the docs now name it.

Signed-off-by: Christoph Knittel <ck@cca.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe
@github-actions

Copy link
Copy Markdown

Semantic Diff

1 commit · Full page

Add make test-rewatch-rust for the Rust build system

1b84245 · Christoph Knittel with Claude Opus 5.5 · Oct 23, 2026

The Rust build system's docs gave make test-rewatch as its test command, but since #8780 that target runs the suite against the OCaml rescript and does not build rescript-rust. The new target builds the Rust binary and runs the suite against it, and the docs now name it.

@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8983

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@8983

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8983

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8983

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8983

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8983

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8983

commit: 1b84245

@github-actions

Copy link
Copy Markdown

@cknitt
cknitt marked this pull request as ready for review October 23, 2026 09:24
@cknitt

cknitt commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T09:26:45.604627Z 1b84245 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 1b84245630

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cknitt
cknitt requested a review from cristianoc October 23, 2026 09:31
@cknitt
cknitt enabled auto-merge (squash) October 23, 2026 09:31
@cknitt
cknitt merged commit 52bf5de into master Oct 23, 2026
26 checks passed
@cknitt
cknitt deleted the drift-8969-test-rewatch-docs branch October 23, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make test-rewatch is documented as the Rust build system's test command but tests the OCaml one

2 participants