Repository navigation
Add make test-rewatch-rust for the Rust build system - #8983
Conversation
The Rust build system's docs gave `make test-rewatch` as its test command, but since #8780 that target runs the suite against the OCaml `rescript` and does not build `rescript-rust`. The new target builds the Rust binary and runs the suite against it, and the docs now name it. Signed-off-by: Christoph Knittel <ck@cca.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe
Semantic Diff1 commit · Full page Add make test-rewatch-rust for the Rust build system1b84245 · Christoph Knittel with Claude Opus 5.5 · Oct 23, 2026 The Rust build system's docs gave |
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8983 |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Fixes #8969.
Since #8780,
make test-rewatchrunsrewatch/tests/suite.shagainstrescript.exe, the OCaml build system, and depends only onlib, so it doesn't buildrescript-rust. The Rust build system's README and AGENTS.md still gave it as their test command, so following them after changingrewatch/src/*.rsneither rebuilt nor tested the Rust binary.This adds
make test-rewatch-rust, which depends onlibandrewatchand runs the same suite againstrescript-rust.exe. That is the command CI runs on linux-arm64. The Rust docs now name the new target and say thatmake test-rewatchtests the OCaml implementation; the root AGENTS.md lists both.test-allis unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe