Repository navigation
Render the semantic diff with the workflow's own scripts - #8963
Conversation
Semantic Diff1 commit · Full page Render the semantic diff with the workflow's own scripts2abf182 · Christoph Knittel with Claude Opus 5.5 · Oct 22, 2026 A pull request's run takes the workflow from its merge into master but checked out the renderer from the branch, so a branch made before #8958 passed --markdown to a commitRecords.js that took it for a revision. The renderer now comes from the merge as well. |
A pull request's run takes the workflow from its merge into master but checked out the renderer from the branch, so a branch made before #8958 passed --markdown to a commitRecords.js that took it for a revision. The renderer now comes from the merge as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp Signed-off-by: Christoph Knittel <ck@cca.io>
2abf182 to
d1edaff
Compare
Semantic Diff1 commit · Full page Render the semantic diff with the workflow's own scriptsd1edaff · Christoph Knittel with Claude Opus 5.5 · Oct 22, 2026 A pull request's run takes the workflow from its merge into master but checked out the renderer from the branch, so a branch made before #8958 passed --markdown to a commitRecords.js that took it for a revision. The renderer now comes from the merge as well. |
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8963 |
For a
pull_requestevent, GitHub runs the workflow file of the pull request's test merge into master, but the Semantic Diff workflow checked out its scripts from the pull request's head. A branch made before #8958 therefore ran master's workflow, which passes--markdown,--urland--since, against its oldcommitRecords.js, which read--markdownas a revision:This failed the latest runs on the #8951 stack (#8950, #8948, #8949).
The checkout now takes
github.sha, the merge commit the workflow itself comes from, so the workflow and the scripts always match: master's tooling plus whatever the pull request changes in it. The rendered commits are unchanged, since the renderer reads them through thepr-<N>ref. Fork pull requests (pull_request_target) keep checking out the base branch.🤖 Generated with Claude Code
https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp