Repository navigation
docs(v13): model class inheritance with phantom types - #1466
Closed
fhammerschmidt wants to merge 2 commits into
Closed
fhammerschmidt wants to merge 2 commits into
fhammerschmidt wants to merge 2 commits into
Conversation
Replace private aliases and explicit coercions with phantom type parameters constrained by polymorphic variants. Keep the Animal, Mammal, and Dog JavaScript hierarchy and method bindings, allowing Dog values to call parent methods directly. Update the interface example and move the cross-link to the type parameter section.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Point readers of polymorphic variant lower bounds to the practical inheritance binding example that combines them with phantom type parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #1465 to v13. The inheritance example now uses phantom type parameters constrained by polymorphic variants, allowing
dog->Animal.getNamedirectly while rejecting parent values passed toDog.bark.Keep the existing JavaScript
Animal → Mammal → Dogimplementation and@sendmethod bindings. Update the.resiexample and the cross-link under Type Parameter, and link the polymorphic variant page's lower-bound section to the inheritance example. All three changed pages are identical to the v12 update.Validation: the inheritance and type pages pass example compilation and output checks on this branch. All changed pages pass formatting and the full relative-link check. MDX compilation and a runtime fixture using the exact documented bindings and JavaScript passed for the identical v12 content, including rejection checks for invalid subclass calls and missing parent tags.
Follow-up to #1463.