chore: remove weights-gen tool#2959
Merged
markphelps merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
The weights pipeline is now formalized through `cog weights import` and the lockfile format. This ad-hoc test-data generator is no longer needed -- developers can use the real CLI commands with a cog.yaml instead.
Contributor
|
LGTM |
michaeldwan
added a commit
that referenced
this pull request
Apr 23, 2026
…nal symbols Remove tools/weights-gen/ (dead developer utility, matches #2959) and unexport ~26 symbols in pkg/model/ and pkg/model/weightsource/ that were only exported for that tool. Delete ParseFingerprint which had zero production callers. This shrinks the public API surface of pkg/model without changing any behavior — all callers are package-internal (same-package tests included).
markphelps
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weights pipeline is now formalized through
cog weights importand the lockfile format.weights-genwas an ad-hoc developer utility for generating synthetic weight directories and lockfiles without needing real model weights or a registry.With the real CLI commands covering this workflow, nobody's actively using the tool -- and it's been accumulating maintenance debt (there's an outstanding update needed for v2 lockfile changes that never happened).
Removes
tools/weights-gen/and its.gitignoreentry.