fix(compose): registry nginx mounts the front include dir (#1111) - #1113
Merged
Merged
Conversation
…1110) The agent image never pre-creates ~/.config/opencode, and main() wrote opencode.json without mkdir-ing its parent, so every OpenRouter-routed spawn exited 1 on FileNotFoundError before the CLI ever started (same crash on fe-dev-1, fe-pm, the auditor). The bash-guard plugin write already mkdir'd its parents; the config write now does the same. Regression test mirrors the plugin-write parents test with a missing .config/opencode prefix.
deploy/nginx.conf includes /etc/nginx/front/active-upstreams.conf (the blue-green color switch), but docker-compose.registry.yml never mounted the repo's ./front directory, so fresh `make quickstart` crash-looped roboco-nginx on the missing include while everything else came up healthy. The build compose has carried the directory mount since the 2026-09-17 blue-green flip; the registry compose now carries the byte-identical block. Directory bind, not a file bind: a file bind pins the inode and deploy-nas.sh's atomic tmp+mv swap would never reach the running container. Guard test pins the ./front:/etc/nginx/front:ro mount in BOTH compose files and that front/active-upstreams.conf exists in the repo, so a future compose fork cannot reintroduce the fresh-install crash.
|
Thanks for opening your first pull request on RoboCo! Quick checklist before review (most of these are enforced by CI, but worth a glance):
See CONTRIBUTING.md for the full workflow and the Code of Conduct for the community standards we follow. Welcome aboard — a maintainer will review shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked onto #1109 (merges into the devops PR, then rides it to slave). Independent of #1112 (different files); both target
feat/devops-agent.Bug
deploy/nginx.confincludes/etc/nginx/front/active-upstreams.conf(the blue-green color switch), butdocker-compose.registry.ymlnever mounted the repo's./frontdirectory, so freshmake quickstartcrash-loopedroboco-nginxon the missing include while everything else came up healthy. Fixes #1111.Fix
The registry compose now carries the byte-identical nginx volumes block the build compose has had since the 2026-09-17 blue-green flip:
- ./front:/etc/nginx/front:ro. Directory bind, not a file bind, sodeploy-nas.sh's atomic tmp+mv color swap still reaches the running container. The issue's suggesteddeploy/front/layout was NOT adopted: it would fork the file of recorddeploy-nas.shalready flips.Guard
New
test_nginx_mounts_front_include_dir_in_every_composepins the directory mount in BOTH compose files and the presence of the shipped include, so a compose fork cannot reintroduce the fresh-install crash.Verification
test_compose_roles.py,test_nginx_routing.py,test_openrouter_cli_config.pypass locally