Skip to content

Move runtime check to tests and other minor changes - #2496

Merged
simonkrogmann merged 3 commits into
remindmodel:developfrom
simonkrogmann:housekeeping
Oct 14, 2026
Merged

simonkrogmann merged 3 commits into
remindmodel:developfrom
simonkrogmann:housekeeping

Conversation

@simonkrogmann

@simonkrogmann simonkrogmann commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Purpose of this PR

Various small changes I collected over the last few days:

  • Move a runtime check that takes several seconds from running before every remind run to the tests.
  • Add a make command for upgrading the renv.
  • documentation for R 4.6

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ◻️ GAMS Code
  • ☑️ R-scripts
  • ☑️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ☑️ Refactoring
  • ☑️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

@simonkrogmann simonkrogmann changed the title Move runtime check to tests and minor changes Move runtime check to tests and other minor changes Oct 14, 2026
@simonkrogmann
simonkrogmann merged commit e543975 into remindmodel:develop Oct 14, 2026
3 of 13 checks passed
@simonkrogmann
simonkrogmann deleted the housekeeping branch October 14, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants