Skip to content

stream: wait out Connecting before watching for GOAWAY #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meling merged 1 commit into from
Oct 13, 2026
Merged

stream: wait out Connecting before watching for GOAWAY #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/stream/outbound.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,16 @@ func (c *OutboundChannel) open() (*session, error) {
// watchGoAway drains s once the connection leaves Ready, which is how the
// client observes a server GOAWAY. Pending calls then complete on s while new
// requests go to a new stream. It returns when ctx ends.
//
// The connection may still report Connecting just after the stream opens.
// That is not a GOAWAY, so the watcher waits for Ready first; draining then
// would end a healthy session and lose the one-way messages it had accepted.
func (c *OutboundChannel) watchGoAway(ctx context.Context, s *session) {
for c.conn.GetState() == connectivity.Connecting {
if !c.conn.WaitForStateChange(ctx, connectivity.Connecting) {
return
}
}
for c.conn.GetState() == connectivity.Ready {
if !c.conn.WaitForStateChange(ctx, connectivity.Ready) {
return
Expand Down
Loading