Repository navigation
fix(studio): Digital IO 1 can't be the trigger input — only Digital IO 2 reaches EINT (#168) - #234
Merged
2 commits merged intoSep 29, 2026
Merged
2 commits merged into
2 commits merged into
Conversation
…O 2 reaches EINT (#168) Only the "Digital IO 2 (5V)" BNC is wired to the panels' EINT net (U3 + J30 shunt); Digital IO 1 has no route, so `in_trigger` there gave a silently dead trigger. - parseRigIo: `in_trigger` on dio port 1 degrades to off with a warning naming Digital IO 2 (shown in the Console log at connect). - Studio Rig I/O menu: the Digital IO 1 `in_trigger` option stays disabled on every firmware, with the reason as its tooltip; capability gating no longer enables it. - Rig-io apply path: never sends SET_DIO_ROLE in_trigger to channel 1. - Tests: N12io-c2 (parser + static Studio checks). The controller-side refusal is reiserlab/LED-Display_G6_Firmware_Arena#45. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 29, 2026
…ng it It can never be valid (no EINT route on that BNC), so a permanently disabled option was clutter. The reason moves into the Digital IO 1 label/select tooltips; the parser warning and the apply guard stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mbreiser
added a commit
that referenced
this pull request
Sep 29, 2026
…ly Digital IO 2 reaches EINT (#168)
mbreiser
added a commit
that referenced
this pull request
Sep 29, 2026
…ly Digital IO 2 reaches EINT (#168)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #168. Only the Digital IO 2 (5V) BNC is wired to the panels' trigger input (the EINT net, via U3 and the J30 shunt). Digital IO 1 has no route. The Studio still let you pick
in_triggerfor Digital IO 1, which gave a trigger that silently does nothing.parseRigIoturnsin_triggeron dio port 1 intooffand warns: "dio port 1 cannot be in_trigger: only "Digital IO 2 (5V)" reaches the panels' trigger input (EINT); treated as off". The warning appears in the Console log at connect. No shipped rig file declares it, but hand-edited rig files could.in_triggeroption stays disabled on every firmware, and its tooltip gives the reason. Capability gating no longer enables it.SET_DIO_ROLE in_triggerto channel 1, whatever set the menu.The controller-side refusal is reiserlab/LED-Display_G6_Firmware_Arena#45.
Tier
next candidate (candidate 2, with #219 and #233)
Release notes
Studio
Test plan
pixi run testgreen (new N12io-c2 checks: parser, disabled option, no gating, apply guard)node --check)in_triggergreyed out with the reason; Digital IO 2in_triggerstill enables on io_ext firmware🤖 Generated with Claude Code