Repository navigation
Add toolbox link to the help page and normalize unknown CNS soma sides - #179
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain, and the requested behavior is covered by tests.
Pull request overview
Adds a toolbox link to the help page and normalizes unknown CNS soma-side values.
Changes:
- Links
connectome_interpreterin the help page. - Maps unknown CNS sides to
"U". - Adds unit tests for fallback behavior.
File summaries
| File | Description |
|---|---|
test/test_dataset_adapters.py |
Tests CNS soma-side normalization and fallback cascade. |
templates/help.html.jinja |
Adds the toolbox link. |
src/neuview/dataset_adapters.py |
Normalizes unknown side values to "U". |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link Yijie Yin's connectome_interpreter from the Population Spatial Coverage help section (closes #70). Map the literal "unknown" rootSide value from male-cns:v1.0 to the internal "U" in the CNS adapter and cover the soma side cascade with unit tests (related to #93).